Fix domFor hitting null dom elements in while loop

thequailman · thequailman · commit 641cddc1ee14 · 2025-04-02T20:01:18.000-05:00
diff --git a/render/domFor.js b/render/domFor.js
@@ -2,7 +2,7 @@
 
 var delayedRemoval = new WeakMap
 
-function *domFor(vnode) {
+function* domFor(vnode) {
 	// To avoid unintended mangling of the internal bundler,
 	// parameter destructuring is not used here.
 	var dom = vnode.dom
@@ -18,7 +18,7 @@ function *domFor(vnode) {
 
 		dom = nextSibling
 	}
-	while (domSize)
+	while (domSize && dom != null)
 }
 
 module.exports = {

Original file line number	Diff line number	Diff line change
`@@ -2,7 +2,7 @@`
`2`	`2`
`3`	`3`	`var delayedRemoval = new WeakMap`
`4`	`4`
`5`		`-function *domFor(vnode) {`
	`5`	`+function* domFor(vnode) {`
`6`	`6`	`// To avoid unintended mangling of the internal bundler,`
`7`	`7`	`// parameter destructuring is not used here.`
`8`	`8`	`var dom = vnode.dom`
`@@ -18,7 +18,7 @@ function *domFor(vnode) {`
`18`	`18`
`19`	`19`	`dom = nextSibling`
`20`	`20`	`}`
`21`		`- while (domSize)`
	`21`	`+ while (domSize && dom != null)`
`22`	`22`	`}`
`23`	`23`
`24`	`24`	`module.exports = {`