Skip to content

All completions show up as 'warning' when using Salsa #364

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
DanielRosenwasser opened this issue Sep 23, 2015 · 4 comments
Closed

All completions show up as 'warning' when using Salsa #364

DanielRosenwasser opened this issue Sep 23, 2015 · 4 comments
Labels
Bug

Comments

@DanielRosenwasser
Copy link
Member

image

This is somewhat confusing and not very helpful.
@hoanhtien
Copy link
Contributor

I can repro. @billti may have a better idea on why this happens.

@DanielRosenwasser
Copy link
Member Author

It's because the plugin just always prints out the script element kind; in this case it's ScriptElementKind.warning which is just set to "warning".

In Visual Studio, we probably check for it specifically.

@zhengbli
Copy link
Contributor

zhengbli commented Oct 2, 2015

And also the received completion list from Salsa server needs to be sorted according to importance. Otherwise the list would be sorted alphabetically which makes it appear broken. Making this a bug.

@zhengbli zhengbli closed this as completed Oct 2, 2015
@zhengbli zhengbli reopened this Oct 2, 2015
@zhengbli zhengbli added the Bug label Oct 2, 2015
@zhengbli
Copy link
Contributor

zhengbli commented Nov 9, 2015

The latest Salsa bits already fixed this behavior. Closing.

@zhengbli zhengbli closed this as completed Nov 9, 2015
@kitsonk kitsonk mentioned this issue Nov 23, 2015
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@DanielRosenwasser @zhengbli @hoanhtien