All completions show up as 'warning' when using Salsa

[DanielRosenwasser]

This is somewhat confusing and not very helpful.

[hoanhtien]

I can repro. @billti may have a better idea on why this happens.

[DanielRosenwasser]

It's because the plugin just always prints out the script element kind; in this case it's ScriptElementKind.warning which is just set to "warning".

In Visual Studio, we probably check for it specifically.

[zhengbli]

And also the received completion list from Salsa server needs to be sorted according to importance. Otherwise the list would be sorted alphabetically which makes it appear broken. Making this a bug.

[zhengbli]

The latest Salsa bits already fixed this behavior. Closing.