-
Notifications
You must be signed in to change notification settings - Fork 5.4k
test: adds blockaid multiple network support test #22691
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
CLA Signature Action: All authors have signed the CLA. You may need to manually re-run the blocking PR check if it doesn't pass in a few minutes. |
| ) | ||
| .withJsonBodyIncluding({ | ||
| method: 'eth_chainId', | ||
| }) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
there was a default mock for Arbitrum that another test is using, that returns the chain id to any request made to Arbitrum RPC. We don't want this mock to be applied to all requests, since now we need to mock different requests, so this mock is now only applied when the chainId method is called - preserving the other test functionality, as well as making it work with new Arbitrum mocks added in this PR
Builds ready [b180b6a]
Page Load Metrics (833 ± 16 ms)
Bundle size diffs
|
Builds ready [04c3ed7]
Page Load Metrics (863 ± 42 ms)
Bundle size diffs
|
Description
This PR adds an e2e spec for testing Blockaid support to multiple networks. This verifies that:
Related issues
Fixes: https://github.com/MetaMask/MetaMask-planning/issues/993
Manual testing steps
yarn test:e2e:single test/e2e/tests/ppom-blockaid-alert-networks-support.spec.js --browser=chromeScreenshots/Recordings
Pre-merge author checklist
Pre-merge reviewer checklist