-
-
Notifications
You must be signed in to change notification settings - Fork 4
Fix: Updated yarn version to 4.10.3 to resolve npmMinimalAgeGate error #156
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Probably best to use the latest version of Yarn: https://github.com/yarnpkg/berry/releases/tag/%40yarnpkg%2Fcli%2F4.10.3 It includes some bug fixes, including at least one related to this option |
ec5cdba to
d0128c0
Compare
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks like the old Yarn binary is still there - could you delete .yarn/releases/yarn-4.5.1.cjs?
|
Also when I try to update Yarn locally using |
Gudahtt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! I confirmed that the Yarn binary is identical to what yarn set version 4.10.3 downloads.
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. Here is the PR to fix it MetaMask/github-tools#156. --> ## **Description** Fix the error discussed in slack here: https://consensys.slack.com/archives/C09B64PEHAQ/p1763403469760889 Discussion in MM Extension for same issue: https://consensys.slack.com/archives/C09B64PEHAQ/p1761903353525079 ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: none ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates the release PR workflow to use a newer MetaMask/github-tools ref and aligns the github-tools-version input. > > - **CI** > - Update `MetaMask/github-tools` reusable workflow ref in `.github/workflows/create-release-pr.yml` to `6a04e4d0c8c25680a7543cfcd2e2fb7125b6759c`. > - Align `with.github-tools-version` to the same ref. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8c79719. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
<!-- Please submit this PR as a draft initially. Do not mark it as "Ready for review" until the template has been completely filled out, and PR status checks have passed at least once. Here is the PR to fix it MetaMask/github-tools#156. --> ## **Description** Fix the error discussed in slack here: https://consensys.slack.com/archives/C09B64PEHAQ/p1763403469760889 Discussion in MM Extension for same issue: https://consensys.slack.com/archives/C09B64PEHAQ/p1761903353525079 ## **Changelog** <!-- If this PR is not End-User-Facing and should not show up in the CHANGELOG, you can choose to either: 1. Write `CHANGELOG entry: null` 2. Label with `no-changelog` If this PR is End-User-Facing, please write a short User-Facing description in the past tense like: `CHANGELOG entry: Added a new tab for users to see their NFTs` `CHANGELOG entry: Fixed a bug that was causing some NFTs to flicker` (This helps the Release Engineer do their job more quickly and accurately) --> CHANGELOG entry: none ## **Related issues** Fixes: ## **Manual testing steps** ```gherkin Feature: my feature name Scenario: user [verb for user action] Given [describe expected initial app state] When user [verb for user action] Then [describe expected outcome] ``` ## **Screenshots/Recordings** <!-- If applicable, add screenshots and/or recordings to visualize the before and after of your change. --> ### **Before** <!-- [screenshots/recordings] --> ### **After** <!-- [screenshots/recordings] --> ## **Pre-merge author checklist** - [ ] I’ve followed [MetaMask Contributor Docs](https://github.com/MetaMask/contributor-docs) and [MetaMask Mobile Coding Standards](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/CODING_GUIDELINES.md). - [ ] I've completed the PR template to the best of my ability - [ ] I’ve included tests if applicable - [ ] I’ve documented my code using [JSDoc](https://jsdoc.app/) format if applicable - [ ] I’ve applied the right labels on the PR (see [labeling guidelines](https://github.com/MetaMask/metamask-mobile/blob/main/.github/guidelines/LABELING_GUIDELINES.md)). Not required for external contributors. ## **Pre-merge reviewer checklist** - [ ] I've manually tested the PR (e.g. pull and build branch, run the app, test code being changed). - [ ] I confirm that this PR addresses all acceptance criteria described in the ticket it closes and includes the necessary testing evidence such as recordings and or screenshots. <!-- CURSOR_SUMMARY --> --- > [!NOTE] > Updates the release PR workflow to use a newer MetaMask/github-tools ref and aligns the github-tools-version input. > > - **CI** > - Update `MetaMask/github-tools` reusable workflow ref in `.github/workflows/create-release-pr.yml` to `6a04e4d0c8c25680a7543cfcd2e2fb7125b6759c`. > - Align `with.github-tools-version` to the same ref. > > <sup>Written by [Cursor Bugbot](https://cursor.com/dashboard?tab=bugbot) for commit 8c79719. This will update automatically on new commits. Configure [here](https://cursor.com/dashboard?tab=bugbot).</sup> <!-- /CURSOR_SUMMARY -->
Update yarn version to 4.10.0 to fix the NPMMinimalAgeGate Error in create-release-pr workflows in extension discussed here. https://consensys.slack.com/archives/C09B64PEHAQ/p1761903353525079
related to yarn:
Preparing [email protected] for immediate activation...
Usage Error: Unrecognized or legacy configuration settings found: npmMinimalAgeGate - run "yarn config -v" to see the list of settings supported in Yarn (in /home/runner/work/metamask-extension/metamask-extension/.yarnrc.yml, /home/runner/work/metamask-extension/metamask-extension/github-tools/.yarnrc.yml)
$ yarn install [--json] [--immutable] [--immutable-cache] [--refresh-lockfile] [--check-cache] [--check-resolutions] [--inline-builds] [--mode #0]
Error: Process completed with exit code 1.
Test: https://github.com/consensys-test/metamask-extension-test-workflow2/actions/runs/18980470817/job/54212864714
Note
Upgrades Yarn from 4.5.1 to 4.10.3 by updating the release artifact in
.yarn/releases..yarn/releases/yarn-4.5.1.cjswith.yarn/releases/yarn-4.10.3.cjs.Written by Cursor Bugbot for commit fb18e22. This will update automatically on new commits. Configure here.