Skip to content

Conversation

@OGPoyraz
Copy link
Member

@OGPoyraz OGPoyraz commented Oct 2, 2023

See changelogs

@OGPoyraz OGPoyraz marked this pull request as ready for review October 2, 2023 12:21
@OGPoyraz OGPoyraz requested review from a team as code owners October 2, 2023 12:21
@adonesky1
Copy link
Contributor

I'm currently rebasing and updating this release

@adonesky1 adonesky1 requested a review from legobeat October 3, 2023 15:48
@mcmire
Copy link
Contributor

mcmire commented Oct 4, 2023

I'll check back tomorrow on this, but for anyone who gets to this before I do, feel free to merge this.

matthewwalsh0
matthewwalsh0 previously approved these changes Oct 4, 2023
vinistevam
vinistevam previously approved these changes Oct 4, 2023
mcmire
mcmire previously requested changes Oct 4, 2023
Copy link
Contributor

@mcmire mcmire left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like we need to update changelogs again. I will do another review and make changes as necessary.

- Add changelog entries for transaction-controller
- Bump transaction-controller to 14.0.0
- Add changelog entries for assets-controllers
@mcmire mcmire dismissed stale reviews from vinistevam and matthewwalsh0 via f5a6dc5 October 4, 2023 17:44
@mcmire mcmire dismissed their stale review October 4, 2023 18:05

I've added the necessary changelog entries.

@mcmire
Copy link
Contributor

mcmire commented Oct 4, 2023

^ This is now ready for another review, hopefully we can get this merged soon.

Copy link
Contributor

@adonesky1 adonesky1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@mcmire
Copy link
Contributor

mcmire commented Oct 4, 2023

Hmm, looks like we need a review from snaps-devs. Requesting...

@mcmire mcmire merged commit add71d1 into main Oct 4, 2023
@mcmire mcmire deleted the release/81.0.0 branch October 4, 2023 20:15
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Alex <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: OGPoyraz <[email protected]>
Co-authored-by: legobeat <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 11, 2023
Co-authored-by: Alex <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: OGPoyraz <[email protected]>
Co-authored-by: legobeat <[email protected]>
MajorLift pushed a commit that referenced this pull request Oct 12, 2023
Co-authored-by: Alex <[email protected]>
Co-authored-by: Elliot Winkler <[email protected]>
Co-authored-by: OGPoyraz <[email protected]>
Co-authored-by: legobeat <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

9 participants