From fea359ae3cb1da5b143401a3aef5e620b213e912 Mon Sep 17 00:00:00 2001 From: Connor Date: Thu, 3 Oct 2024 22:37:02 -0400 Subject: [PATCH 1/2] Fixed Google Collab Embedding issue issue 3741 --- manim/utils/ipython_magic.py | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/manim/utils/ipython_magic.py b/manim/utils/ipython_magic.py index 601d4d6f8e..8ce6e46511 100644 --- a/manim/utils/ipython_magic.py +++ b/manim/utils/ipython_magic.py @@ -3,12 +3,13 @@ from __future__ import annotations import mimetypes +import os import shutil from datetime import datetime from pathlib import Path from typing import Any -from manim import config, logger, tempconfig +from manim import Group, config, logger, tempconfig from manim.__main__ import main from manim.renderer.shader import shader_program_cache @@ -168,7 +169,7 @@ def construct(self): file_type = mimetypes.guess_type(config["output_file"])[0] embed = config["media_embed"] - if embed is None: + if embed is False: # videos need to be embedded when running in google colab. # do this automatically in case config.media_embed has not been # set explicitly. From 30c67e9b1c141c7dc1f8564fff3deddd8646b3e7 Mon Sep 17 00:00:00 2001 From: "pre-commit-ci[bot]" <66853113+pre-commit-ci[bot]@users.noreply.github.com> Date: Fri, 4 Oct 2024 02:39:30 +0000 Subject: [PATCH 2/2] [pre-commit.ci] auto fixes from pre-commit.com hooks for more information, see https://pre-commit.ci --- manim/utils/ipython_magic.py | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/manim/utils/ipython_magic.py b/manim/utils/ipython_magic.py index 8ce6e46511..9938f7f1e5 100644 --- a/manim/utils/ipython_magic.py +++ b/manim/utils/ipython_magic.py @@ -3,13 +3,12 @@ from __future__ import annotations import mimetypes -import os import shutil from datetime import datetime from pathlib import Path from typing import Any -from manim import Group, config, logger, tempconfig +from manim import config, logger, tempconfig from manim.__main__ import main from manim.renderer.shader import shader_program_cache