seaice_timeseries.replicate_cycles is producing a plot that is too long

[xylar]

My recent changes to replicate_cycles in #111 is producing some strange results. The time variable of dsShift should be clipped to be as close as possible to the same as that of ds.

[xylar]

GitHub won't let me upload a picture right now. I'll try again later...

[milenaveneziani]

do you understand why we didn't see this in our tests?

[xylar]

[xylar]

There's the picture.

do you understand why we didn't see this in our tests?

Hmm, I guess I must have just been careless because this plot is right out of my output from #111. Sorry about that. But it should be quite easy to fix.

[milenaveneziani]

well, I did not get that in my test. I wonder if it has to do with the adjustment you made when I said that I was seeing one less cycle. Mine looked good after you made the change, but for some reason this one does not.

[xylar]

Right, I think that's exactly what happened. But it makes sense to have as much as 1 cycle too many like here and then just crop off the last bit to best match the end time of the ds. I think that will be an easy fix when I get around to it.

[milenaveneziani]

agreed.

[milenaveneziani]

Addressed by #132.