Skip to content

WIP: Added button prop for more flexible camera button handling. #28

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

WIP: Added button prop for more flexible camera button handling. #28

wants to merge 2 commits into from

Conversation

@alexanderkjeldaas
Copy link

For non-mobile use-cases, I need to have the button outside the camera view. With the new button prop, I can pass null to accomplish this.

@thenationofalex
Copy link

Is there any chance of this being merged in?

@alexanderkjeldaas
Copy link
Author

Resolved conflicts.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

1 more reviewer

@d-feliz d-feliz d-feliz approved these changes

Reviewers whose approvals may not affect merge requirements

At least 1 approving review is required to merge this pull request.

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@alexanderkjeldaas @thenationofalex @d-feliz