Skip patching .csproj files when assembly definitions are available #79
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Contributor
|
Thank you for pull request and investigation! We are preparing to accept this fix. We will add it to the CHANGELOG in your fix branch, and once that is done, We will merge it. |
Contributor
Author
|
Thank you for reviewing my pull request! |
wada-at-live2d-com
approved these changes
Apr 30, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
For Unity versions 2017.3 and later, which support Assembly Definitions,
the CubismAssetProcessor will skip patching the
.csprojfiles.Motivation
Since unsafe code is allowed through
csc.rsp,mcs.rsp, andLive2D.Cubism.asmdeffiles,it is now safe to stop adding or modifying the
AllowUnsafeBlockssetting in.csprojfiles.Furthermore, the JetBrains Rider IDE does not support the
OnGeneratedCSProjectFilesmethod and issues a warning when this method is defined.With this change, users will be freed from unnecessary processing costs and the effort required to ignore such warnings.