Fix typing for Logger files

[daniellepintz]

Proposed refactor

Fix typing for these files:
https://github.com/PyTorchLightning/pytorch-lightning/blob/7eab379da2fdca542849ed4ad313d0851c2271e3/pyproject.toml#L61-L68

Motivation

As part of #7037 we want to add typing to the entire Lightning codebase.

Additional Context

Make sure you do one PR per file.
Start by removing the file from pyproject.toml. To test mypy locally make sure you have it installed and then simply run mypy.

cc @Borda @justusschock @awaelchli @akihironitta @rohitgr7 @edward-io @ananthsub @kamil-kaczmarek @Raalsky @Blaizzy

[learn2phoenix]

Could I take this?

[daniellepintz]

Yup go for it! Just assigned it to you :)

[daniellepintz]

@learn2phoenix are you still planning to work on this issue?

[learn2phoenix]

@daniellepintz Sorry, have been ultra busy. I will push the PR this weekend.

[daniellepintz]

No worries! Just checking in. If you do, please do one PR per file :)

[learn2phoenix]

@daniellepintz Working on this today, so our expectation should be no errors from mypy on these files or is there more to it? Also, what is generally done if stub files for a module are missing?

[learn2phoenix]

some of these files have name conflicts with library names or other modules. Would changing the names of these loggers/* files be an acceptable solution? If so, is there any specific naming convention that needs to be used or would something like <current_name>_log.py be ok?

[daniellepintz]

Yes the expectation is no errors from mypy on these files.

Which files have name conflicts? These conflicts show up on mypy?

[learn2phoenix]

yes, they do show up like the following:
wandb.py: error: Source file found twice under different module names: "pytorch_lightning.loggers.wandb" and "wandb"

Also, mypy reports the stubs to be missing for some modules like torch_xla, comet_ml and says that they wouldn't be analyzed. Are we ignoring these errors?

[daniellepintz]

I see! @awaelchli wdyt?

[awaelchli]

This was completed as part of #13445