-
Notifications
You must be signed in to change notification settings - Fork 665
Open an existing file instead of creating a new one when showing the problem #59
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Comments
@taoweicn This is a good suggestion. @SkyLin0909 Do you mean to make the extension work as @taoweicn said? |
@jdneo yes |
@jdneo Hi,请问这是一个 PR-welcomed 的 issue 么? |
@poppinlp All the issues are PR welcomed. Just remember to discuss the implementation in the issue before sending out the PR. Thanks |
@jdneo This issue is caused by the params we passed into the So here may be some plans: A: We could genearte the file name by ourself and by which we could do the existence checking to determine whether to use the local code or get the remote template by This could solve this problem but we may meet some new problems too:
B: We could use It's a little bit simple solution but may cost more time since we will always call the API. So, what's your option about this? I prefer the plan A and i feel free for any ideas. :) |
@poppinlp Plan A sounds good to me. Would you like to make a PR for it? |
Of course. I'll send it this weekend. :) |
The text was updated successfully, but these errors were encountered: