Skip to content

Conversation

@HRanjan-11
Copy link
Contributor

No description provided.

function sync_args_from_cmd(args) {
return new Promise(function (resolve, reject) {
let rawdata = fs.readFileSync(args["lambdatest-config-file"]);
let lt_config = JSON.parse(rawdata);

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

try..catch here.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

}
if (dot_env_vars) {
dot_env_vars = dot_env_vars.trim();
dot_env_vars = dot_env_vars.split(",");

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lets use a diff var

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

dot_env_vars = dot_env_vars.split(",");
if ("envfl" in args) {
envFilePath = args["envfl"];
} else if (lt_config["run_settings"]["env_file"]) {

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lt_config["run_settings"] && lt_config["run_settings"]["env_file"]

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done

Copy link

@shubhamlt shubhamlt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

pl do the commented changes

@HRanjan-11 HRanjan-11 merged commit e1b3c08 into LambdaTest:dev Nov 10, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants