-
Notifications
You must be signed in to change notification settings - Fork 30
fetching username and access key from .env for triggering test only #271
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
commands/utils/set_args.js
Outdated
| function sync_args_from_cmd(args) { | ||
| return new Promise(function (resolve, reject) { | ||
| let rawdata = fs.readFileSync(args["lambdatest-config-file"]); | ||
| let lt_config = JSON.parse(rawdata); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
try..catch here.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
commands/utils/set_args.js
Outdated
| } | ||
| if (dot_env_vars) { | ||
| dot_env_vars = dot_env_vars.trim(); | ||
| dot_env_vars = dot_env_vars.split(","); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lets use a diff var
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
commands/utils/set_args.js
Outdated
| dot_env_vars = dot_env_vars.split(","); | ||
| if ("envfl" in args) { | ||
| envFilePath = args["envfl"]; | ||
| } else if (lt_config["run_settings"]["env_file"]) { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
lt_config["run_settings"] && lt_config["run_settings"]["env_file"]
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
shubhamlt
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
pl do the commented changes
No description provided.