chore(js): Allow triggering release on external artifact static_viewer.html
#70
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…r.html Previously, when a new version of static_viewer.html is released on the master of vtk-js we couldn't trigger a release because we do not commit this file but rather grab it during release. This commit adds the hash of the latest version in a file and a hash check that runs during release but does not trigger a failure on a mismatch but rather a warning. So now if static_viewer.html is updated on vtk-js: - If we do not care `.fetch_externals.sh` will just emit a warning - If we **do** care we update .static_viewer.sha256 and trigger a new release on trame-vtk even if no other `trame-vtk` change happened during last release.
ChristosT
added a commit
to ChristosT/trame-vtk
that referenced
this pull request
May 6, 2024
Similar to offline_viewer.html we track and report mismatched hash of all external dependencies. see also Kitware#70
jourdain
pushed a commit
that referenced
this pull request
May 6, 2024
Similar to offline_viewer.html we track and report mismatched hash of all external dependencies. see also #70
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, when a new version of static_viewer.html is released on the master of vtk-js we couldn't trigger a release because we do not commit this file but rather grab it during release.
This commit adds the hash of the latest version in a file and a hash check that runs during release but does not trigger a failure on a mismatch but rather a warning.
So now if static_viewer.html is updated on vtk-js:
.fetch_externals.shwill just emit a warning.static_viewer.sha256and trigger a new release on trame-vtk even if no othertrame-vtkchange happened during last release.cc: @jourdain