Skip to content

Conversation

@kirankv21
Copy link
Collaborator

No description provided.

},
)

# Create agent with Siren tools
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@kirankv21
can we please remove all the fairly intuitive comments across the codebase

@@ -0,0 +1,19 @@
# Core dependencies
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

are these dependencies to run the examples ? If so create a README inside examples on how these can be run

@@ -0,0 +1,86 @@
[build-system]
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file necessary ?

Copy link
Collaborator Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yes, this file is necessary according to latest standards

@@ -0,0 +1,16 @@
"""Siren Agent Toolkit for Python."""
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit, lets name the dir agenttoolkit

Copy link
Collaborator

@joobi-keyvalue joobi-keyvalue left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, please do check on the comments and add unit tests for all tools exposed

@kirankv21 kirankv21 requested a review from joobi-keyvalue July 11, 2025 08:32
@kirankv21 kirankv21 merged commit a6d97cd into main Jul 11, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants