-
Notifications
You must be signed in to change notification settings - Fork 1
[feat]: Add python agent toolkit #18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
…d default factory for notify field
python/examples/crewai/main.py
Outdated
| }, | ||
| ) | ||
|
|
||
| # Create agent with Siren tools |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@kirankv21
can we please remove all the fairly intuitive comments across the codebase
python/requirements.txt
Outdated
| @@ -0,0 +1,19 @@ | |||
| # Core dependencies | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
are these dependencies to run the examples ? If so create a README inside examples on how these can be run
| @@ -0,0 +1,86 @@ | |||
| [build-system] | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
is this file necessary ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, this file is necessary according to latest standards
| @@ -0,0 +1,16 @@ | |||
| """Siren Agent Toolkit for Python.""" | |||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nit, lets name the dir agenttoolkit
joobi-keyvalue
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks good, please do check on the comments and add unit tests for all tools exposed
… reorganize files
No description provided.