highlander: remove the utf8 function

Author: StefanKarpinski

base/REPL.jl

@@ -323,11 +323,11 @@ An editor may have converted tabs to spaces at line """
 
 function hist_getline(file)
     while !eof(file)
-        line = utf8(readline(file))
+        line = readline(file)
         isempty(line) && return line
         line[1] in "\r\n" || return line
     end
-    return utf8("")
+    return ""
 end
 
 function hist_from_file(hp, file)

base/docs/helpdb/Base.jl

@@ -1871,7 +1871,7 @@ Dict{String,Float64} with 2 entries:
   "bar" => 42.0
   "foo" => 0.0
 
-julia> b = Dict(utf8("baz") => 17, utf8("bar") => 4711)
+julia> b = Dict("baz" => 17, "bar" => 4711)
 Dict{String,Int64} with 2 entries:
   "bar" => 4711
   "baz" => 17
@@ -2984,29 +2984,6 @@ Extract a named field from a `value` of composite type. The syntax `a.b` calls
 """
 getfield
 
-"""
-    utf8(::Array{UInt8,1})
-
-Create a UTF-8 string from a byte array.
-"""
-utf8(::Vector{UInt8})
-
-"""
-    utf8(::Ptr{UInt8}, [length])
-
-Create a UTF-8 string from the address of a C (0-terminated) string encoded in UTF-8. A copy
-is made; the ptr can be safely freed. If `length` is specified, the string does not have to
-be 0-terminated.
-"""
-utf8(::Ptr{UInt8}, length::Int = 1)
-
-"""
-    utf8(s)
-
-Convert a string to a contiguous UTF-8 string (all characters must be valid UTF-8 characters).
-"""
-utf8(s)
-
 """
     hvcat(rows::Tuple{Vararg{Int}}, values...)
 

base/env.jl

@@ -34,7 +34,7 @@ function access_env(onError::Function, str::AbstractString)
     var = cwstring(str)
     len = _getenvlen(var)
     if len == 0
-        return Libc.GetLastError() != ERROR_ENVVAR_NOT_FOUND ? utf8("") : onError(str)
+        return Libc.GetLastError() != ERROR_ENVVAR_NOT_FOUND ? "" : onError(str)
     end
     val = zeros(UInt16,len)
     ret = ccall(:GetEnvironmentVariableW,stdcall,UInt32,(Ptr{UInt16},Ptr{UInt16},UInt32),var,val,len)

base/exports.jl

@@ -891,7 +891,6 @@ export
     ucfirst,
     unescape_string,
     uppercase,
-    utf8,
     warn,
     xdump,
 

base/libc.jl

@@ -259,7 +259,7 @@ function FormatMessage end
                     FORMAT_MESSAGE_ALLOCATE_BUFFER | FORMAT_MESSAGE_FROM_SYSTEM | FORMAT_MESSAGE_IGNORE_INSERTS | FORMAT_MESSAGE_MAX_WIDTH_MASK,
                     C_NULL, e, 0, lpMsgBuf, 0, C_NULL)
         p = lpMsgBuf[1]
-        len == 0 && return utf8("")
+        len == 0 && return ""
         buf = Array(UInt16, len)
         unsafe_copy!(pointer(buf), p, len)
         ccall(:LocalFree,stdcall,Ptr{Void},(Ptr{Void},),p)

base/libgit2.jl

@@ -459,7 +459,7 @@ function snapshot(repo::GitRepo)
     work = try
         with(GitIndex, repo) do idx
             if length(readdir(path(repo))) > 1
-                add!(idx, utf8("."))
+                add!(idx, ".")
                 write!(idx)
             end
             write_tree!(idx)

base/precompile.jl

@@ -400,7 +400,6 @@ precompile(Base.UInt, (UInt,))
 precompile(Base.unsafe_copy!, (Array{Dict{Any, Any}, 1}, Int, Array{Dict{Any, Any}, 1}, Int, Int))
 precompile(Base.unsafe_copy!, (Ptr{Dict{Any, Any}}, Ptr{Dict{Any, Any}}, Int))
 precompile(Base.unshift!, (Array{Any,1}, Task))
-precompile(Base.utf8, (String,))
 precompile(Base.uv_error, (String, Bool))
 precompile(Base.uvfinalize, (Base.TTY,))
 precompile(Base.vcat, (Base.LineEdit.Prompt,))

base/regex.jl

@@ -210,8 +210,8 @@ function matchall(re::Regex, str::String, overlap::Bool=false)
     matches
 end
 
-matchall(re::Regex, str::Union{String,SubString}, overlap::Bool=false) =
-    matchall(re, utf8(str), overlap)
+matchall(re::Regex, str::SubString, overlap::Bool=false) =
+    matchall(re, String(str), overlap)
 
 function search(str::Union{String,SubString}, re::Regex, idx::Integer)
     if idx > nextind(str,endof(str))

base/show.jl

@@ -1130,7 +1130,7 @@ Accept keyword args `c` for alternate single character marker.
 """
 function replace_with_centered_mark(s::AbstractString;c::Char = '⋅')
     N = length(s)
-    return join(setindex!([utf8(" ") for i=1:N],string(c),ceil(Int,N/2)))
+    return join(setindex!([" " for i=1:N],string(c),ceil(Int,N/2)))
 end
 
 """

base/unicode/utf8.jl

@@ -230,7 +230,6 @@ write(io::IO, s::String) = write(io, s.data)
 
 ## transcoding to UTF-8 ##
 
-utf8(x) = convert(String, x)
 convert(::Type{String}, s::String) = s
 
 function convert(::Type{String}, dat::Vector{UInt8})
@@ -307,7 +306,7 @@ function convert(::Type{String}, a::Vector{UInt8}, invalids_as::AbstractString)
     end
     String(a)
 end
-convert(::Type{String}, s::AbstractString) = utf8(bytestring(s))
+convert(::Type{String}, s::AbstractString) = bytestring(s)
 
 """
 Converts an already validated vector of `UInt16` or `UInt32` to a `String`
@@ -351,6 +350,3 @@ function encode_to_utf8{T<:Union{UInt16, UInt32}}(::Type{T}, dat, len)
     end
     String(buf)
 end
-
-utf8(p::Ptr{UInt8}) = String(bytestring(p))
-utf8(p::Ptr{UInt8}, len::Integer) = utf8(pointer_to_array(p, len))