type stability of matrix functions #1360
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #1360 +/- ##
=======================================
Coverage 93.75% 93.75%
=======================================
Files 34 34
Lines 15730 15731 +1
=======================================
+ Hits 14748 14749 +1
Misses 982 982 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Member
|
Would be good for @jishnub to take a look. |
jishnub
reviewed
Jun 1, 2025
jishnub
reviewed
Jun 1, 2025
jishnub
reviewed
Jun 1, 2025
Co-authored-by: Jishnu Bhattacharya <[email protected]>
jishnub
reviewed
Jun 2, 2025
jishnub
reviewed
Jun 2, 2025
jishnub
reviewed
Jun 5, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I've fixed the type stability of matrix functions as far as possible without changing the API as discussed in #1130. Also added tests. Closes #460.