introdocs + demo + instructions on writing good rules #103
Conversation
oxinabox
changed the title
|
We can break this up later into multiple pages in the docs. When reviewing this remember you can render in the github markdown renderer.
After reviewing this PR. |
|
Is this ready for review, or are you still actively working on it? |
|
One generic comment, can we collapse a lot of these lines together. It seems like you typed this up in If you don't mind, I can push changes for that just let me know! |
| using Zygote | ||
| Zygote.gradient(foo, x) | ||
| # (-2.0638950738662625,) | ||
| ``` |
There was a problem hiding this comment.
@wesselb @willtebbutt can have Nabla example?
I tried but failed to get Nabla to do this.
Nope, I wrote it directly in markdown. I just like to break-lines more than I should. |
simeonschaub
left a comment
simeonschaub
left a comment
There was a problem hiding this comment.
Great work, this will definitely be appreciated! Should we also reference this in a CONTRIBUTING file?
docs/src/index.md
Outdated
| - `Δx` is the input to a propagator, (i.e a _seed_ for a _pullback_; or a _perturbation_ for a _pushforward_) | ||
| - `∂x` is the output of a propagator | ||
| - `dx` could be anything, including a pullback. It really should show up outside of tests. | ||
| - `ẋ` is a derivative moving forward. |
There was a problem hiding this comment.
| - `ẋ` is a derivative moving forward. | |
| - `ẋ` is the intermediary partial derivative used for forward-mode. |
docs/src/index.md
Outdated
| - `∂x` is the output of a propagator | ||
| - `dx` could be anything, including a pullback. It really should show up outside of tests. | ||
| - `ẋ` is a derivative moving forward. | ||
| - `x̄` is a dderivative moving backward. |
There was a problem hiding this comment.
| - `x̄` is a dderivative moving backward. | |
| - `x̄` is the intermediary sensitivity used for reverse-mode. |
Co-Authored-By: Seth Axen <[email protected]> Co-Authored-By: Mateusz Baran <[email protected]>
Co-Authored-By: simeonschaub <[email protected]>
Co-Authored-By: simeonschaub <[email protected]>
Co-Authored-By: simeonschaub <[email protected]>
Co-Authored-By: simeonschaub <[email protected]>
|
This should be about the last of it. |
|
merging in 1 hour. |
Preview: http://www.juliadiff.org/ChainRules.jl/preview-PR103/
Old OP:
This will describe the post JuliaDiff/ChainRulesCore.jl#30
world, so we won't merge this til after that then.
But reading this will help reviewers of that PR and
#91