Don't deepcopy on identity map and broadcast

Author: oschulz

src/array_of_similar_arrays.jl

@@ -221,8 +221,8 @@ function deepmap(f::Base.Callable, A::ArrayOfSimilarArrays{T,M,N}) where {T,M,N}
 end
 
 
-Base.map(::typeof(identity), A::ArrayOfSimilarArrays) = deepcopy(A)
-Base.Broadcast.broadcasted(::typeof(identity), A::ArrayOfSimilarArrays) = deepcopy(A)
+Base.map(::typeof(identity), A::ArrayOfSimilarArrays) = A
+Base.Broadcast.broadcasted(::typeof(identity), A::ArrayOfSimilarArrays) = A
 
 
 Base.@pure _result_is_nested(idxs_outer::Tuple, idxs_inner::Tuple) =

src/vector_of_arrays.jl

@@ -419,8 +419,8 @@ function deepmap(f::Base.Callable, A::VectorOfArrays)
 end
 
 
-Base.map(::typeof(identity), A::VectorOfArrays) = deepcopy(A)
-Base.Broadcast.broadcasted(::typeof(identity), A::VectorOfArrays) = deepcopy(A)
+Base.map(::typeof(identity), A::VectorOfArrays) = A
+Base.Broadcast.broadcasted(::typeof(identity), A::VectorOfArrays) = A
 
 
 

test/array_of_similar_arrays.jl

@@ -359,9 +359,7 @@ using StatsBase: cov2cor
         A = nestedview(A_flat, 2)
 
         for do_map in (map, broadcast)
-            @test @inferred(do_map(identity, A)) == A
-            do_map(identity, A) isa ArrayOfSimilarArrays
-            @test do_map(identity, A) !== A
+            @test @inferred(do_map(identity, A)) === A
         end
     end
 end

test/vector_of_arrays.jl

@@ -339,9 +339,7 @@ using ArraysOfArrays: full_consistency_checks, append_elemptr!, element_ptr
         A = VectorOfArrays(ref_AoA2(Float32, 4))
 
         for do_map in (map, broadcast)
-            @test @inferred(do_map(identity, A)) == A
-            do_map(identity, A) isa VectorOfArrays
-            @test do_map(identity, A) !== A
+            @test @inferred(do_map(identity, A)) === A
         end
     end
 end