Skip to content

Conversation

@TSGut
Copy link
Member

@TSGut TSGut commented Apr 26, 2022

Symmetric() means we don't actually have to store some zero bands when initially generating them.

@codecov
Copy link

codecov bot commented Apr 26, 2022

Codecov Report

Merging #122 (c847428) into master (e065da9) will increase coverage by 0.26%.
The diff coverage is 100.00%.

@@            Coverage Diff             @@
##           master     #122      +/-   ##
==========================================
+ Coverage   95.97%   96.23%   +0.26%     
==========================================
  Files           4        4              
  Lines         720      718       -2     
==========================================
  Hits          691      691              
+ Misses         29       27       -2     
Impacted Files Coverage Δ
src/disk.jl 98.22% <100.00%> (+0.86%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e065da9...c847428. Read the comment docs.

@TSGut
Copy link
Member Author

TSGut commented Apr 26, 2022

@dlfivefifty Ready for merge.

@dlfivefifty
Copy link
Member

(technically not a "memory optimization" as Zeros doesn't use any memory...)

@dlfivefifty dlfivefifty merged commit 83421e6 into JuliaApproximation:master Apr 26, 2022
@TSGut
Copy link
Member Author

TSGut commented Apr 26, 2022

Interesting, I thought explicitly constructed zeros are still stored! In that case just a minor tidying of a redundancy. :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants