Skip to content

Commit cc55ca5

Browse files
committed
verify facebook#258 and facebook#256: add without +x to tasks/pack.sh, e2e.sh shall fail, and CI shall fail
1 parent 319d272 commit cc55ca5

File tree

3 files changed

+3
-2
lines changed

3 files changed

+3
-2
lines changed

package.json

+1-1
Original file line numberDiff line numberDiff line change
@@ -13,7 +13,7 @@
1313
"scripts": {
1414
"start": "node scripts/start.js --debug-template",
1515
"build": "node scripts/build.js --debug-template",
16-
"create-react-app": "node global-cli/index.js --scripts-version \"$PWD/`npm pack`\"",
16+
"create-react-app": "node global-cli/index.js --scripts-version \"$PWD/`tasks/pack.sh`\"",
1717
"test": "tasks/e2e.sh"
1818
},
1919
"files": [

tasks/e2e.sh

+1-1
Original file line numberDiff line numberDiff line change
@@ -47,7 +47,7 @@ perl -i -p0e 's/bundledDependencies.*?]/bundledDependencies": []/s' package.json
4747

4848
# Pack react-scripts
4949
npm install
50-
scripts_path=$PWD/`npm pack`
50+
scripts_path=$PWD/`tasks/pack.sh`
5151

5252
# lint
5353
./node_modules/.bin/eslint --ignore-path .gitignore ./

tasks/pack.sh

+1
Original file line numberDiff line numberDiff line change
@@ -0,0 +1 @@
1+
echo `npm pack`

0 commit comments

Comments
 (0)