fix: IOSession access this before calling super

Jack-Works · Jack-Works · commit 1cf58c399432 · 2020-10-15T13:08:52.000+08:00
close microsoft#40399 This makes the TS server crashes if the build target is ES6 or higher.
diff --git a/src/tsserver/server.ts b/src/tsserver/server.ts
@@ -484,8 +484,9 @@ namespace ts.server {
         private constructed: boolean | undefined;
 
         constructor() {
+            let isConstructed = false;
             const event: Event | undefined = (body: object, eventName: string) => {
-                if (this.constructed) {
+                if (isConstructed) {
                     this.event(body, eventName);
                 }
                 else {
@@ -539,6 +540,7 @@ namespace ts.server {
             }
 
             this.constructed = true;
+            isConstructed = true;
         }
 
         event<T extends object>(body: T, eventName: string): void {

Original file line number	Diff line number	Diff line change
`@@ -484,8 +484,9 @@ namespace ts.server {`
`484`	`484`	`private constructed: boolean \| undefined;`
`485`	`485`
`486`	`486`	`constructor() {`
	`487`	`+ let isConstructed = false;`
`487`	`488`	`const event: Event \| undefined = (body: object, eventName: string) => {`
`488`		`- if (this.constructed) {`
	`489`	`+ if (isConstructed) {`
`489`	`490`	`this.event(body, eventName);`
`490`	`491`	`}`
`491`	`492`	`else {`
`@@ -539,6 +540,7 @@ namespace ts.server {`
`539`	`540`	`}`
`540`	`541`
`541`	`542`	`this.constructed = true;`
	`543`	`+ isConstructed = true;`
`542`	`544`	`}`
`543`	`545`
`544`	`546`	`event<T extends object>(body: T, eventName: string): void {`