feat: Issue add right click option to delete custom bst style #14525
+80
−9
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
koppor
requested changes
Dec 5, 2025
| dialogService.showFileOpenDialog(fileDialogConfiguration).ifPresent(bstFile -> viewModel.addBstStyle(bstFile)); | ||
| } | ||
|
|
||
| @SuppressWarnings("unused") |
|
|
||
| ## [Unreleased] | ||
|
|
||
| - We added a right-click "Delete" option for custom BST styles in the Entry Preview settings, allowing users to easily remove imported styles. [#14352](https://github.com/JabRef/jabref/issues/14352) |
Member
There was a problem hiding this comment.
Why not following keep-a-changelog format?
Comment on lines
-155
to
+158
| availableListView.selectionModelProperty().getValue().selectedItemProperty().addListener((observable, oldValue, newValue) -> | ||
| availableListView.selectionModelProperty().getValue().selectedItemProperty().addListener((_observable, _oldValue, newValue) -> |
| } | ||
|
|
||
| public void removeBstStyle(PreviewLayout layout) { | ||
| if (!(layout instanceof BstPreviewLayout bstLayout)) { |
Member
There was a problem hiding this comment.
no assignment to variable needed.
Why isn't the method parameter dirctly BstPreviewLayout?
| public void addBstStyle(Path bstFile) { | ||
| BstPreviewLayout bstPreviewLayout = new BstPreviewLayout(bstFile); | ||
| bstStylesPaths.add(bstFile); | ||
| manuallyAddedBstPaths.add(bstFile); // Mark as manually added |
Member
There was a problem hiding this comment.
The comment states the obvious. Talk about the WHY
| }) | ||
| .executeWith(taskExecutor); | ||
| bstStylesPaths.clear(); | ||
| manuallyAddedBstPaths.clear(); // Reset the set of manually added files |
Member
There was a problem hiding this comment.
The comment states the obvious. Talk about the WHY
| setPreviewLayout(chosenSelectionModelProperty.getValue().getSelectedItem()); | ||
| } | ||
|
|
||
| @SuppressWarnings("SameParameterValue") |
github-actions
bot
added
the
status: changes-required
github-actions
bot
removed
the
status: changes-required
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #14352
Adds the functionality to delete manually added BST files from the Customization dialog. When a user right-clicks on a manually imported BST file used for entry preview, a "Delete" option now appears in the context menu, allowing easy removal.
Steps to test
Mandatory checks
CHANGELOG.mdin a way that is understandable for the average user (if change is visible to the user)