Add ADR for migration from Apache Commons to Picocli #13096
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: subhramit <[email protected]>
Signed-off-by: subhramit <[email protected]>
subhramit
commented
May 10, 2025
|
|
||
| 1. **Commands and Subcommands**: Picocli's strong support for nested commands makes it easier to organize complex command-line applications with multiple features. | ||
|
|
||
| 2. **Modularization**: Better organization of code through a more modular structure, with each command potentially having its own class. |
Member
Author
There was a problem hiding this comment.
"potentially having" - I don't like this line. Maybe result of some hallucination, need to make this more concrete.
Member
Author
Yeah, Sherlock. Because there is no code. |
Signed-off-by: subhramit <[email protected]>
Signed-off-by: subhramit <[email protected]>
Signed-off-by: subhramit <[email protected]>
Signed-off-by: subhramit <[email protected]>
Signed-off-by: subhramit <[email protected]>
Member
Author
What? |
Member
Spam, just reported this. Don't mind it, the github team will remove that nonsense |
calixtus
reviewed
May 10, 2025
Member
|
@Siedlerchr can you check JCommander option? |
|
@trag-bot didn't find any issues in the code! ✅✨ |
calixtus
approved these changes
May 10, 2025
Contributor
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Siedlerchr
added a commit
that referenced
this pull request
May 12, 2025
…ddLobidIsbnFetcher * 'addLobidIsbnFetcher' of github.com:JabRef/jabref: (26 commits) Bump com.konghq:unirest-java-core from 4.4.6 to 4.4.7 (#13104) Bump ai.djl:bom from 0.32.0 to 0.33.0 (#13106) Bump org.openrewrite.rewrite from 7.5.0 to 7.6.1 (#13105) Bump com.tngtech.archunit:archunit-junit5-engine from 1.4.0 to 1.4.1 (#13103) Bump com.konghq:unirest-modules-gson from 4.4.6 to 4.4.7 (#13102) Bump jablib/src/main/resources/csl-styles from `b8070a7` to `9b777f6` (#13101) Refine http sever doc (#13100) Add type "Bug" (#13099) Fix dash feat: select correct tab for creation of new entry (#13087) (#13091) Add missing empty line Fix notarization flag (#13095) Add more options to ADR-044 (#13098) Update year (#13097) Add ADR for migration from Apache Commons to Picocli (#13096) fix-localization (#13092) Fix condition for "comment-on-pr" fix-git-version (#13093) hotfix: enable ea build also on label added Check label "dev: binary" for upload to builds.jabref.org (#13086) ...
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Follow-up to: #13012
Refs. #110
Add ADR.
Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)