-
-
Notifications
You must be signed in to change notification settings - Fork 3.1k
Fix startup in case of files #13089
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix startup in case of files #13089
Conversation
| // Run the actual open in a thread to prevent the program | ||
| // locking until the file is loaded. | ||
| if (!filesToOpen.isEmpty()) { | ||
| assert fileUpdateMonitor != null; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Using assertions for null checks is not recommended for production code as they can be disabled. Consider using JSpecify @nonnull annotations for better null safety.
|
@trag-bot didn't find any issues in the code! ✅✨ |
|
Failing build is due to timeout on cache-restore and issues connecting to gradle server. |
|
The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build. |
Follow-up to #13012
fileUpdateMonitorwas not initalized properly.Additionally, this PR enables
assertstatements to be evaluted.Mandatory checks
CHANGELOG.mddescribed in a way that is understandable for the average user (if change is visible to the user)