Skip to content

Conversation

@koppor
Copy link
Member

@koppor koppor commented May 9, 2025

Follow-up to #13012

fileUpdateMonitor was not initalized properly.

Additionally, this PR enables assert statements to be evaluted.

Mandatory checks

  • I own the copyright of the code submitted and I license it under the MIT license
  • [/] Change in CHANGELOG.md described in a way that is understandable for the average user (if change is visible to the user)
  • [/] Tests created for changes (if applicable)
  • Manually tested changed features in running JabRef (always required)
  • [/] Screenshots added in PR description (if change is visible to the user)
  • [/] Checked developer's documentation: Is the information available and up to date? If not, I outlined it in this pull request.
  • [/] Checked documentation: Is the information available and up to date? If not, I created an issue at https://github.com/JabRef/user-documentation/issues or, even better, I submitted a pull request to the documentation repository.

@koppor koppor added the automerge PR is tagged with that label will be merged if workflows are green label May 9, 2025
jabref-machine
jabref-machine previously approved these changes May 9, 2025
@koppor koppor enabled auto-merge May 9, 2025 21:23
Siedlerchr
Siedlerchr previously approved these changes May 9, 2025
// Run the actual open in a thread to prevent the program
// locking until the file is loaded.
if (!filesToOpen.isEmpty()) {
assert fileUpdateMonitor != null;
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Using assertions for null checks is not recommended for production code as they can be disabled. Consider using JSpecify @nonnull annotations for better null safety.

@koppor koppor dismissed stale reviews from Siedlerchr and jabref-machine via 9c12e1e May 9, 2025 21:36
@trag-bot
Copy link

trag-bot bot commented May 9, 2025

@trag-bot didn't find any issues in the code! ✅✨

@koppor
Copy link
Member Author

koppor commented May 9, 2025

Failing build is due to timeout on cache-restore and issues connecting to gradle server.

@koppor koppor added automerge PR is tagged with that label will be merged if workflows are green and removed automerge PR is tagged with that label will be merged if workflows are green labels May 9, 2025
@koppor koppor added this pull request to the merge queue May 9, 2025
@github-actions
Copy link
Contributor

github-actions bot commented May 9, 2025

The build for this PR is no longer available. Please visit https://builds.jabref.org/main/ for the latest build.

Merged via the queue into main with commit 43e5a7d May 9, 2025
2 checks passed
@koppor koppor deleted the fix-startup branch May 9, 2025 22:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

automerge PR is tagged with that label will be merged if workflows are green

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants