-
Notifications
You must be signed in to change notification settings - Fork 651
[Shared] Add exit command as an alias to quit #1220
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
|
Note there's a slight QoL decrease because |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
"exec" is a command used, in general, by slightly more experienced players so not having it on full auto-completion is less of a hindrance than adding the common "console-killer command" imo.
|
We could also argue that |
Maybe over the top but in my fork I added a cvar for the exit command, default to on. I advised the few who complained about it interrupting their exec muscle memory to disable the exit command with the cvar. |
|
I guess that works, but it's not worth the additional complexity to me. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm okay with that change. I doubt anyone will complain. If someone has a valid reason against this, we can easily revert this again.
|
I just write |
Unsupported in openjk 😂 |
|
I am rather cautious regarding new built-in commands on OpenJK. OpenJK has already added a built in I am with @taysta on this: I would prefer to have a cvar to enable this (and I would prefer it defaulting to off). However at that point one could consider to add a generic alias system to let users define custom rewrites (which could also be useful when playing on custom mods). |
I can't tell you how many times I've tried to close a server with
exitlike most other CLI programs, interpreters, shells etc.Quality of life for a goober like me ✨