Skip to content

Conversation

@Razish
Copy link
Member

@Razish Razish commented Feb 29, 2024

I can't tell you how many times I've tried to close a server with exit like most other CLI programs, interpreters, shells etc.

Quality of life for a goober like me ✨

@Razish Razish requested a review from a team as a code owner February 29, 2024 17:08
@Razish
Copy link
Member Author

Razish commented Mar 2, 2024

Note there's a slight QoL decrease because ex<TAB> no longer completes to exec 🤔
I'll leave this to the masses to decide which is better.

Copy link

@bartrpe bartrpe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"exec" is a command used, in general, by slightly more experienced players so not having it on full auto-completion is less of a hindrance than adding the common "console-killer command" imo.

@Razish
Copy link
Member Author

Razish commented Mar 5, 2024

We could also argue that ex<TAB> for exec is only saving 1 keystroke (c). Not likely to end the world.

@taysta
Copy link
Contributor

taysta commented Mar 5, 2024

We could also argue that ex<TAB> for exec is only saving 1 keystroke (c). Not likely to end the world.

Maybe over the top but in my fork I added a cvar for the exit command, default to on. I advised the few who complained about it interrupting their exec muscle memory to disable the exit command with the cvar.

@Razish
Copy link
Member Author

Razish commented Mar 6, 2024

I guess that works, but it's not worth the additional complexity to me.
We go all-in or we don't add it at all IMO.

Copy link
Member

@SomaZ SomaZ left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm okay with that change. I doubt anyone will complain. If someone has a valid reason against this, we can easily revert this again.

@xiaoxiao921
Copy link

I just write qui gon jinn in the console and it works

@ensiform
Copy link
Member

ensiform commented Aug 4, 2024

I just write qui gon jinn in the console and it works

Unsupported in openjk 😂

@Daggolin
Copy link
Contributor

I am rather cautious regarding new built-in commands on OpenJK. OpenJK has already added a built in help command that overrides the help commands from custom serverside mods, because the client no longer forwards the command to the server (unless the client uses cmd help). And EternalJK added an internal login command that no longer forwarded the command on servers that were using serverside mods EternalJK was not familiar with. So I don't really like the idea of adding exit as alias for quit.

I am with @taysta on this: I would prefer to have a cvar to enable this (and I would prefer it defaulting to off). However at that point one could consider to add a generic alias system to let users define custom rewrites (which could also be useful when playing on custom mods).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

8 participants