Remove an incorrect impl of ReadOnlySystemParam for NonSendMut (bevyengine#7243)

joseph-gio · ItsDoot · commit ecc400637857 · 2023-01-31T20:00:18.000-06:00
# Objective The trait `ReadOnlySystemParam` is implemented for `NonSendMut`, when it should not be. This mistake was made in bevyengine#6919. ## Solution Remove the incorrect impl.
diff --git a/crates/bevy_ecs/src/system/system_param.rs b/crates/bevy_ecs/src/system/system_param.rs
@@ -1012,9 +1012,6 @@ unsafe impl<T: 'static> SystemParam for Option<NonSend<'_, T>> {
     }
 }
 
-// SAFETY: Only reads a single non-send resource
-unsafe impl<'a, T: 'static> ReadOnlySystemParam for NonSendMut<'a, T> {}
-
 // SAFETY: NonSendMut ComponentId and ArchetypeComponentId access is applied to SystemMeta. If this
 // NonSendMut conflicts with any prior access, a panic will occur.
 unsafe impl<'a, T: 'static> SystemParam for NonSendMut<'a, T> {

Original file line number	Diff line number	Diff line change
`@@ -1012,9 +1012,6 @@ unsafe impl<T: 'static> SystemParam for Option<NonSend<'_, T>> {`
`1012`	`1012`	`}`
`1013`	`1013`	`}`
`1014`	`1014`
`1015`		`-// SAFETY: Only reads a single non-send resource`
`1016`		`-unsafe impl<'a, T: 'static> ReadOnlySystemParam for NonSendMut<'a, T> {}`
`1017`		`-`
`1018`	`1015`	`// SAFETY: NonSendMut ComponentId and ArchetypeComponentId access is applied to SystemMeta. If this`
`1019`	`1016`	`// NonSendMut conflicts with any prior access, a panic will occur.`
`1020`	`1017`	`unsafe impl<'a, T: 'static> SystemParam for NonSendMut<'a, T> {`