Skip to content

Commit 6b48f35

Browse files
committed
(fix) SQL super features missing sub-features
- According to the MSDN documentation for the 'SQL' feature https://msdn.microsoft.com/en-us/library/ms144259.aspx#Feature The following feature parameters should be included: BC Conn SSMS ADV_SSMS SDK
1 parent ecbb042 commit 6b48f35

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

lib/puppet_x/sqlserver/server_helper.rb

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -3,7 +3,7 @@ module Sqlserver
33
class ServerHelper
44
@super_feature_hash = {
55
:SQL => [:DQ, :FullText, :Replication, :SQLEngine],
6-
:Tools => [:SSMS, :ADV_SSMS, :Conn]
6+
:Tools => [:BC, :SSMS, :ADV_SSMS, :Conn, :SDK]
77
}
88

99
def self.get_sub_features(super_feature)

spec/unit/puppet/provider/sqlserver_features_spec.rb

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -61,7 +61,7 @@
6161
context 'it should expand the superset for features' do
6262
include_context 'features'
6363
let(:additional_params) { {:features => %w(Tools)} }
64-
let(:munged_args) { {:features => %w(ADV_SSMS Conn SSMS)} }
64+
let(:munged_args) { {:features => %w(ADV_SSMS BC Conn SDK SSMS)} }
6565
it_should_behave_like 'create'
6666
end
6767

@@ -109,7 +109,7 @@
109109
context 'it should install the expanded tools set' do
110110
include_context 'features'
111111
@feature_params[:features] = %w(Tools)
112-
let(:feature_add) { %w(ADV_SSMS Conn SSMS) }
112+
let(:feature_add) { %w(ADV_SSMS BC Conn SDK SSMS) }
113113
it_should_behave_like 'features=', @feature_params
114114
end
115115

0 commit comments

Comments
 (0)