(maint) modify acceptance install for new config

 - Introduce new sql_host role that can be used to identify a node
   to install SQL Server on.
 - Add additional metadata called sql_version to each node
   definition to specify installation of SQL 2012 or 2014

Author: Zach Reichert

spec/acceptance/nodesets/windows-2012r2-64a-inverted.yml renamed to spec/acceptance/nodesets/win_2012r2_sql2012.yml

@@ -7,25 +7,19 @@ HOSTS:
     platform: debian-6-i386
     template: debian-6-i386
     hypervisor: vcloud
-  sql2012:
+  win2012r2:
     roles:
       - agent
-      - default
-      - sql2012
-    platform: windows-2012r2-x86_64
-    template: win-2012r2-x86_64
-    hypervisor: vcloud
-  sql2014:
-    roles:
-      - agent
-      - sql2014
+      - sql_host
     platform: windows-2012r2-x86_64
     template: win-2012r2-x86_64
     hypervisor: vcloud
+    sql_version: 2012
 CONFIG:
   nfs_server: none
   consoleport: 443
   datastore: instance0
   folder: Delivery/Quality Assurance/FOSS/Dynamic
   resourcepool: delivery/Quality Assurance/FOSS/Dynamic
   pooling_api: http://vcloud.delivery.puppetlabs.net/
+  forge_host: api-module-staging.puppetlabs.com

spec/spec_helper_acceptance.rb

@@ -10,7 +10,8 @@
   # Readable test descriptions
   c.formatter = :documentation
   c.before(:suite) do
-    base_install
+    host = find_only_one('sql_host')
+    base_install(host['sql_version'])
   end
 end
 

spec/sql_testing_helpers.rb

@@ -65,32 +65,24 @@ def run_sql_query(host, opts = {})
   end
 end
 
-def base_install
-  sql2012 = find_only_one('sql2012')
-  step "Mount the ISO on the agent #{sql2012.node_name}"
-  iso_2012_opts = {
-    :qa_iso_resource_root   => QA_RESOURCE_ROOT,
-    :sqlserver_iso          => SQL_2012_ISO,
-    :sqlserver_version      => '2012',
-  }
-  mount_iso(sql2012, iso_2012_opts)
-  step "Install Microsoft SQL 2012 on the agent #{sql2012.node_name} before running any tests"
-  sql2012_opts ={
-    :features => 'SQL',
-  }
-  install_sqlserver(sql2012, sql2012_opts)
-
-  sql2014 = find_only_one('sql2014')
-  step "Mount the ISO on the agent #{sql2014.node_name}"
-  iso_2014_opts = {
-    :qa_iso_resource_root   => QA_RESOURCE_ROOT,
-    :sqlserver_iso          => SQL_2014_ISO,
-    :sqlserver_version      => '2014',
-  }
-  mount_iso(sql2014, iso_2014_opts)
-  step "Install Microsoft SQL 2014 on the agent #{sql2014.node_name} before running any tests"
-  sql2014_opts ={
-    :features => 'SQL',
-  }
-  install_sqlserver(sql2014, sql2014_opts)
+def base_install(sql_version)
+  case sql_version
+  when /2012/
+    iso_opts = {
+      :qa_iso_resource_root   => QA_RESOURCE_ROOT,
+      :sqlserver_iso          => SQL_2012_ISO,
+      :sqlserver_version      => '2012',
+    }
+  when /2014/
+    iso_opts = {
+      :qa_iso_resource_root   => QA_RESOURCE_ROOT,
+      :sqlserver_iso          => SQL_2014_ISO,
+      :sqlserver_version      => '2014',
+    }
+  end
+  host = find_only_one('sql_host')
+  step "Mount the ISO on the aggent #{host.node_name}"
+  mount_iso(host, iso_opts)
+  step "Install Microsoft SQL #{sql_version} on the agent #{host.node_name} before running any tests"
+  install_sqlserver(host, {:features => 'SQL'})
 end