Skip to content

Conversation

@agustinmista
Copy link
Contributor

@agustinmista agustinmista commented Nov 26, 2025

This PR brings in cardano-base and propagates a set of CardanoFeatureFlags from the top-level RunNodeArgs down to the NodeKernelArgs.

This is currently needed by upcoming PRs that need to conditionally enable certain behavior based on the PerasFlag feature flag (e.g, spawning voting and object diffusion threads, deciding when a node can consider itself as CaughtUp, etc.).

@agustinmista
Copy link
Contributor Author

agustinmista commented Nov 26, 2025

Please note that ⚠️this is a breaking change⚠️ for any client invoking run or runWith, as it will be lacking the mandatory rnFeatureFlags field.

Open to suggestions if you think we can/should delay this by providing a default empty value somewhere.

@agustinmista agustinmista self-assigned this Nov 26, 2025
Brings in cardano-base and propagates a set of `CardanoFeatureFlag`s
from the top-level `RunNodeArgs` down to the `NodeKernelArgs`.

This is currently needed by upcoming PRs that need to conditionally
enable certain behavior based on the `PerasFlag` feature flag.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants