Skip to content

Test Conway #1572

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
kderme opened this issue Dec 6, 2023 · 1 comment
Open

Test Conway #1572

kderme opened this issue Dec 6, 2023 · 1 comment
Assignees
Labels
conway Conway integration blockers or reauested feautures

Comments

@kderme
Copy link
Contributor

kderme commented Dec 6, 2023

After transfering existing tests to Conway with #1525, we need to add new tests with the new functionality. A WIP list:

  • Tests that were not transferable because the underslying mechanism has changed: These are MIR tests mirReward, mirRewardDereg, mirReward and tests that require funds in the treasury rewardsDeregistration, rewardsReregistration.
  • Tests for all COnway feautures: drep registrations, voting, voting delegations, ratified and enacted gov actions (TODO: extend)
  • HF tests which use a voted governance action instead of hard coded hard fork based on the epoch number.
@kderme kderme added bug Something isn't working conway Conway integration blockers or reauested feautures and removed bug Something isn't working labels Dec 6, 2023
@sgillespie
Copy link
Contributor

Tests that were not transferable because the underlying mechanism has changed:

The only tests that weren't transferred to Conway were in the "rewards" suite:

  • rewardsDeregistration
  • rewardsReregistration
  • mirReward
  • mirRewardDereg
  • mirReward

So the Conway equivalents will need to be added (if there are any).

All tests that used Shelley certs were updated to use Conway certs, but AFAICT no other behavior changed (other than governance actions)

The only other change in behavior I saw was that the Conway ledger removed duplicate transactions, so we might want to add some tests that verify this in the database.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
conway Conway integration blockers or reauested feautures
Projects
Status: In Progress
Development

No branches or pull requests

2 participants