Skip to content

Conversation

@antonwolfy
Copy link
Contributor

@antonwolfy antonwolfy commented Jul 19, 2024

The PR proposes to add implementation of dpnp.nextafter function which is missing now.

There is new VM functions are added to use nextafter from OneMKL library where it's possible.
In other places the PR propose to leverage on new binary universal function _nextafter function from dpctl implemented in dpctl-1730.

The all affected tests are updated to cover different use cases.

  • Have you provided a meaningful PR description?
  • Have you added a test, reproducer or referred to issue with a reproducer?
  • Have you tested your changes locally for CPU and GPU devices?
  • Have you made sure that new changes do not introduce compiler warnings?
  • Have you checked performance impact of proposed changes?
  • If this PR is a work in progress, are you filing the PR as a draft?

@github-actions
Copy link
Contributor

github-actions bot commented Jul 21, 2024

View rendered docs @ https://intelpython.github.io/dpnp/index.html

@antonwolfy antonwolfy marked this pull request as ready for review July 22, 2024 13:08
Copy link
Contributor

@vtavana vtavana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @antonwolfy!

@antonwolfy antonwolfy merged commit 7b016d9 into master Jul 23, 2024
@antonwolfy antonwolfy deleted the impl_nextafter branch July 23, 2024 22:34
github-actions bot added a commit that referenced this pull request Jul 23, 2024
* Implement dpnp.nextafter

* Add MKL extension for nextafter

* Applied pre-commit hook

* Applied review comments 7b016d9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants