Skip to content

Commit 680d903

Browse files
authored
implement dpnp.nanargmax, dpnp.nanargmin, dpnp.nanmax, and dpnp.nanmin (#1646)
* implement nanargmax, nanargmin, nanmax, nanmin * address comments * suppress overflow warning
1 parent d9c1ca1 commit 680d903

14 files changed

+704
-276
lines changed

dpnp/dpnp_iface_mathematical.py

+8-4
Original file line numberDiff line numberDiff line change
@@ -133,8 +133,8 @@ def _append_to_diff_array(a, axis, combined, values):
133133
134134
Scalar value (including case with 0d array) is expanded to an array
135135
with length=1 in the direction of axis and the shape of the input array `a`
136-
in along all other axes.
137-
Note, if `values` is a scalar. then it is converted to 0d array allocating
136+
along all other axes.
137+
Note, if `values` is a scalar, then it is converted to 0d array allocating
138138
on the same SYCL queue as the input array `a` and with the same USM type.
139139
140140
"""
@@ -1132,7 +1132,9 @@ def fmax(x1, x2, /, out=None, *, where=True, dtype=None, subok=True, **kwargs):
11321132
See Also
11331133
--------
11341134
:obj:`dpnp.maximum` : Element-wise maximum of array elements, propagates NaNs.
1135-
:obj:`dpnp.fmin` : Element-wise minimum of array elements, ignore NaNs.
1135+
:obj:`dpnp.fmin` : Element-wise minimum of array elements, ignores NaNs.
1136+
:obj:`dpnp.max` : The maximum value of an array along a given axis, propagates NaNs..
1137+
:obj:`dpnp.nanmax` : The maximum value of an array along a given axis, ignores NaNs.
11361138
:obj:`dpnp.minimum` : Element-wise minimum of array elements, propagates NaNs.
11371139
:obj:`dpnp.fmod` : Calculate the element-wise remainder of division.
11381140
@@ -1237,7 +1239,9 @@ def fmin(x1, x2, /, out=None, *, where=True, dtype=None, subok=True, **kwargs):
12371239
See Also
12381240
--------
12391241
:obj:`dpnp.minimum` : Element-wise minimum of array elements, propagates NaNs.
1240-
:obj:`dpnp.fmax` : Element-wise maximum of array elements, ignore NaNs.
1242+
:obj:`dpnp.fmax` : Element-wise maximum of array elements, ignores NaNs.
1243+
:obj:`dpnp.min` : The minimum value of an array along a given axis, propagates NaNs.
1244+
:obj:`dpnp.nanmin` : The minimum value of an array along a given axis, ignores NaNs.
12411245
:obj:`dpnp.maximum` : Element-wise maximum of array elements, propagates NaNs.
12421246
:obj:`dpnp.fmod` : Calculate the element-wise remainder of division.
12431247

0 commit comments

Comments
 (0)