Skip to content

Conversation

@fabpot
Copy link
Contributor

@fabpot fabpot commented Oct 12, 2015

No description provided.

composer.json Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest removing @dev here, and adding a build job on Travis changing the minimum stability. This way, most builds will still run against stable versions rather than the 3.0 dev version.

see https://github.com/kriswallsmith/assetic/blob/37bcae173f2ca774ee125ea378690d192596aa29/.travis.yml#L37 for changing the min stability in a job

@benji07
Copy link

benji07 commented Nov 6, 2015

i closed my PR after seeing that one, but It seem this one doesn't work,

https://github.com/Incenteev/ParameterHandler/pull/89/files

@fabpot
Copy link
Contributor Author

fabpot commented Nov 10, 2015

@stof updated

@fabpot
Copy link
Contributor Author

fabpot commented Nov 10, 2015

That's the last blocker for Symfony SE 3.0.

.travis.yml Outdated
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

please remove the --prefer-source, as it would defeat the usage of the Travis cache to persist the composer cache

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

fixed

@fabpot
Copy link
Contributor Author

fabpot commented Nov 10, 2015

All green

@stof
Copy link
Member

stof commented Nov 10, 2015

Thank you @fabpot.

@stof stof merged commit d52008b into Incenteev:master Nov 10, 2015
stof added a commit that referenced this pull request Nov 10, 2015
This PR was merged into the 2.1.x-dev branch.

Discussion
----------

Added Symfony Yaml 3.0 as a valid dep

Commits
-------

d52008b Added Symfony Yaml 3.0 as a valid dep
@fabpot
Copy link
Contributor Author

fabpot commented Nov 10, 2015

Thanks for the merge. Do think you can make a release as well?

@stof
Copy link
Member

stof commented Nov 10, 2015

yes, I'm on it. It will be 2.1.2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants