-
Notifications
You must be signed in to change notification settings - Fork 99
Added Symfony Yaml 3.0 as a valid dep #87
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
composer.json
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I suggest removing @dev here, and adding a build job on Travis changing the minimum stability. This way, most builds will still run against stable versions rather than the 3.0 dev version.
see https://github.com/kriswallsmith/assetic/blob/37bcae173f2ca774ee125ea378690d192596aa29/.travis.yml#L37 for changing the min stability in a job
|
i closed my PR after seeing that one, but It seem this one doesn't work, https://github.com/Incenteev/ParameterHandler/pull/89/files |
|
@stof updated |
|
That's the last blocker for Symfony SE 3.0. |
.travis.yml
Outdated
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
please remove the --prefer-source, as it would defeat the usage of the Travis cache to persist the composer cache
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
fixed
|
All green |
|
Thank you @fabpot. |
This PR was merged into the 2.1.x-dev branch. Discussion ---------- Added Symfony Yaml 3.0 as a valid dep Commits ------- d52008b Added Symfony Yaml 3.0 as a valid dep
|
Thanks for the merge. Do think you can make a release as well? |
|
yes, I'm on it. It will be 2.1.2 |
No description provided.