-
Notifications
You must be signed in to change notification settings - Fork 7
Use new Intl formatter instances where applicable. #1845
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
… properties there.
…Add alwaysLeadingZero prop.
|
@skrustev Kind of weird to me why the resources of the tree are on the item instead of the whole tree. Do we expect each item to handle its own locale and resoruces? |
Yes at least that way the items don't need to be manually updated from the Tree itself and its the same way in Angular anyway. |
rkaraivanov
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM with several comments, some of which are not related to this PR.
However, I do agree that it is strange to have the resource strings on each tree item instead of the parent tree element.
Resolves #1155
Resolves #1904
Calendar:
Intl.DateTimeFormatwith ones fromigniteui-i18n-core. No expected changes in behavior.Combo:
Date Input, Date Picker, Date Range Picker:
igniteui-i18n-core. No expected changes in behavior except for the first item in this list.