Skip to content

Conversation

@skrustev
Copy link
Member

@skrustev skrustev commented Sep 10, 2025

Resolves #1155
Resolves #1904

Calendar:

  • Replaced all instances of Intl.DateTimeFormat with ones from igniteui-i18n-core. No expected changes in behavior.

Combo:

  • Validation strings should be available to set for it as well.

Date Input, Date Picker, Date Range Picker:

  • Fixed default display format acting like input format and not taking into account locale zeroing.
  • Replaced all instances of Intl used with the new date formatter from igniteui-i18n-core. No expected changes in behavior except for the first item in this list.
  • Date Picker and Date Range Picker properly extend base Form validation resources. Setting custom resources through Input for now disabled.

@skrustev skrustev added calendar date-picker date-time-input date-range-picker i18n Issues related to internationalization and localization labels Sep 18, 2025
@skrustev skrustev marked this pull request as ready for review September 18, 2025 16:34
@mddragnev
Copy link
Member

@skrustev Kind of weird to me why the resources of the tree are on the item instead of the whole tree. Do we expect each item to handle its own locale and resoruces?

@skrustev skrustev requested a review from rkaraivanov November 6, 2025 09:23
@skrustev
Copy link
Member Author

skrustev commented Nov 6, 2025

@skrustev Kind of weird to me why the resources of the tree are on the item instead of the whole tree. Do we expect each item to handle its own locale and resoruces?

Yes at least that way the items don't need to be manually updated from the Tree itself and its the same way in Angular anyway.

Copy link
Member

@rkaraivanov rkaraivanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM with several comments, some of which are not related to this PR.
However, I do agree that it is strange to have the resource strings on each tree item instead of the parent tree element.

rkaraivanov
rkaraivanov previously approved these changes Nov 10, 2025
@rkaraivanov rkaraivanov merged commit 6a8ee60 into master Nov 17, 2025
6 checks passed
@rkaraivanov rkaraivanov deleted the skrastev/localization-intl branch November 17, 2025 14:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug]: [Calendar] The label for the week number column is missing Date-Time-Input: support additional time input formats

7 participants