feat: Allow non-string iData values

Author: kadler

src/itoolkit/itoolkit.py

@@ -208,7 +208,7 @@ def make(self):
         xmli += '<' + self.opt['k']
         for k, v in self.opt.items():
             if len(k) > 1:
-                xmli += " " + k + "='" + v + "'"
+                xmli += " " + k + "='" + str(v) + "'"
         xmli += " var='" + self.opt['i'] + "'>"
         if len(self.opt['v']) > 0:
             xmli += '<![CDATA[' + self.opt['v'] + ']]>'
@@ -620,13 +620,16 @@ class iData (iBase): # noqa N801
 
         For more info on data types you can use, refer to
         http://yips.idevcloud.com/wiki/index.php/XMLService/DataTypes
+
+    .. versionchanged:: 1.6.3
+        `ival` now supports non-string parameters.
     """
 
     def __init__(self, ikey, itype, ival, iopt={}):
         opts = {
             'i': ikey,
             'k': 'data',
-            'v': ival,
+            'v': str(ival) if ival is not None else "",
             'type': itype
         }
         super(iData, self).__init__(iopt, opts)

tests/test_unit_data.py

@@ -0,0 +1,47 @@
+import xml.etree.ElementTree as ET
+
+from itoolkit import iData
+
+
+def test_data():
+    key = 'lljqezl'
+    datatype = '10a'
+    value = 'foo'
+
+    element = ET.fromstring(iData(key, datatype, value).xml_in())
+
+    assert(element.tag == 'data')
+    assert(element.attrib['var'] == key)
+    assert(element.attrib['type'] == datatype)
+    assert(element.text == value)
+
+
+def test_data_non_str():
+    key = 'madsn'
+    datatype = '10i0'
+    value = 0
+
+    element = ET.fromstring(iData(key, datatype, value).xml_in())
+
+    assert(element.tag == 'data')
+    assert(element.attrib['var'] == key)
+    assert(element.attrib['type'] == datatype)
+    assert(element.text == str(value))
+
+
+def test_data_and_options():
+    key = 'oiujgoihs'
+    datatype = '10a'
+    value = 'bar'
+    opts = {
+        'dim': 10,
+        'varying': 'on',
+    }
+
+    element = ET.fromstring(iData(key, datatype, value, opts).xml_in())
+    assert(element.tag == 'data')
+    assert(element.attrib['var'] == key)
+    assert(element.attrib['type'] == datatype)
+    for k, v in opts.items():
+        assert(element.attrib[k] == str(v))
+    assert(element.text == value)