-
Notifications
You must be signed in to change notification settings - Fork 421
Asnyc testing #604
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Asnyc testing #604
Conversation
PR Review Comment - Action Items Required🔄 Rebase RequiredThis branch is significantly behind main and needs rebasing before review. ✅ Steps to Fix:1. Rebase on latest maingit fetch origin main
git rebase origin/main2. Resolve conflicts - Keep these from main:
3. Preserve your async changes:
4. Verify after rebase:
5. Clean up commits:
|
Q&A
Github workflows doesn't recognize the new scripts if not included in Manifest
Moved to dev dependencies as they are indeed dev only. Oops! Checks
|
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Sebastian <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
Signed-off-by: Mihai Criveti <[email protected]>
c765154 to
f6f6bf3
Compare
|
Updated PR - Rebased onto main and fixed formatting/linting issues:
All CI checks should now pass cleanly. The branch is up-to-date with main and all formatting/linting tools are satisfied. |
crivetimihai
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rebased and fixed all issues
* Add new Makefile targets Signed-off-by: Sebastian <[email protected]> * Add new config for make targets Signed-off-by: Sebastian <[email protected]> * Add new async testing files Signed-off-by: Sebastian <[email protected]> * Async safety unit test Signed-off-by: Sebastian <[email protected]> * Add github workflow Signed-off-by: Sebastian <[email protected]> * Update documentation Signed-off-by: Sebastian <[email protected]> * Fix yamlint issues Signed-off-by: Sebastian <[email protected]> * Add asyncpg module in workflow Signed-off-by: Sebastian <[email protected]> * Remove installation dependency in workflow Signed-off-by: Sebastian <[email protected]> * Update MANIFEST.in Signed-off-by: Sebastian <[email protected]> * Install dependency for async Signed-off-by: Sebastian <[email protected]> * Fix async testing Signed-off-by: Sebastian <[email protected]> * Remove reports Signed-off-by: Sebastian <[email protected]> * Pylint mcpgateway/bootstrap_db.py Signed-off-by: Sebastian <[email protected]> * Add dev dependencies Signed-off-by: Sebastian <[email protected]> * Relint Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> --------- Signed-off-by: Sebastian <[email protected]> Signed-off-by: Mihai Criveti <[email protected]> Co-authored-by: Sebastian <[email protected]> Co-authored-by: Mihai Criveti <[email protected]>
* Add new Makefile targets Signed-off-by: Sebastian <[email protected]> * Add new config for make targets Signed-off-by: Sebastian <[email protected]> * Add new async testing files Signed-off-by: Sebastian <[email protected]> * Async safety unit test Signed-off-by: Sebastian <[email protected]> * Add github workflow Signed-off-by: Sebastian <[email protected]> * Update documentation Signed-off-by: Sebastian <[email protected]> * Fix yamlint issues Signed-off-by: Sebastian <[email protected]> * Add asyncpg module in workflow Signed-off-by: Sebastian <[email protected]> * Remove installation dependency in workflow Signed-off-by: Sebastian <[email protected]> * Update MANIFEST.in Signed-off-by: Sebastian <[email protected]> * Install dependency for async Signed-off-by: Sebastian <[email protected]> * Fix async testing Signed-off-by: Sebastian <[email protected]> * Remove reports Signed-off-by: Sebastian <[email protected]> * Pylint mcpgateway/bootstrap_db.py Signed-off-by: Sebastian <[email protected]> * Add dev dependencies Signed-off-by: Sebastian <[email protected]> * Relint Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> --------- Signed-off-by: Sebastian <[email protected]> Signed-off-by: Mihai Criveti <[email protected]> Co-authored-by: Sebastian <[email protected]> Co-authored-by: Mihai Criveti <[email protected]>
* Add new Makefile targets Signed-off-by: Sebastian <[email protected]> * Add new config for make targets Signed-off-by: Sebastian <[email protected]> * Add new async testing files Signed-off-by: Sebastian <[email protected]> * Async safety unit test Signed-off-by: Sebastian <[email protected]> * Add github workflow Signed-off-by: Sebastian <[email protected]> * Update documentation Signed-off-by: Sebastian <[email protected]> * Fix yamlint issues Signed-off-by: Sebastian <[email protected]> * Add asyncpg module in workflow Signed-off-by: Sebastian <[email protected]> * Remove installation dependency in workflow Signed-off-by: Sebastian <[email protected]> * Update MANIFEST.in Signed-off-by: Sebastian <[email protected]> * Install dependency for async Signed-off-by: Sebastian <[email protected]> * Fix async testing Signed-off-by: Sebastian <[email protected]> * Remove reports Signed-off-by: Sebastian <[email protected]> * Pylint mcpgateway/bootstrap_db.py Signed-off-by: Sebastian <[email protected]> * Add dev dependencies Signed-off-by: Sebastian <[email protected]> * Relint Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Rebase, lint and fix pylint issues Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> * Cleanup manifest.in Signed-off-by: Mihai Criveti <[email protected]> --------- Signed-off-by: Sebastian <[email protected]> Signed-off-by: Mihai Criveti <[email protected]> Co-authored-by: Sebastian <[email protected]> Co-authored-by: Mihai Criveti <[email protected]>
PR closes #254
Known issues:
make profile-serve) appends the file path twice when opening a report (causing an error)New targets
Make targets
Github workflow
Unit tests