Skip to content

Start alembic revision history #240

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
crivetimihai merged 2 commits into from
Jul 4, 2025
Merged

Start alembic revision history #240

crivetimihai merged 2 commits into from
Jul 4, 2025

Conversation

@madhav165
Copy link
Collaborator

@madhav165 madhav165 commented Jul 4, 2025 •
edited
Loading

🐛 Bug-fix PR

📌 Summary

Start alembic revision history so subsequent changes can build off it

💡 Fix Description

  • Creates the alembic_version table in empty database and stores the latest revision with alembic stamp head
  • If tables exist, does alembic upgrade head
  • Implements migration in a function called from main rather than as a dep

✅ Checklist

  • Code formatted (make black isort pre-commit)
  • No secrets/credentials committed

@madhav165 madhav165 requested a review from crivetimihai as a code owner July 4, 2025 16:17
@madhav165 madhav165 mentioned this pull request Jul 4, 2025
Merged
3 tasks
@madhav165 madhav165 self-assigned this Jul 4, 2025
@crivetimihai
Copy link
Member

crivetimihai commented Jul 4, 2025

  • rm mcp.db; make test
  • make venv install serve # After the redis fix, know issue in Fix/redis import lazy #235
  • make smoketest
  • make docker-prod docker-run-ssl-host
  • export MCPGATEWAY_BEARER_TOKEN=$(python3 -m mcpgateway.utils.create_jwt_token --username admin --exp 0 --secret my-test-key); curl -sk -H "Authorization: Bearer $MCPGATEWAY_BEARER_TOKEN" https://localhost:4444/version
  • make docker-stop compose-down compose-rm; docker volume rm mcp-context-forge_pgdata; make compose-up

crivetimihai
crivetimihai approved these changes Jul 4, 2025
View reviewed changes
Copy link
Member

@crivetimihai crivetimihai left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested and merged

@crivetimihai crivetimihai merged commit 738ca8a into main Jul 4, 2025
23 checks passed
@crivetimihai crivetimihai deleted the modify-alembic-migration branch July 4, 2025 16:34
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
@madhav165
Start alembic revision history (IBM#240)
82a28c2 
* Alembic bootstrap with alembic_version table
Signed-off-by: Madhav Kandukuri <[email protected]>

* Remove migration dependence
Signed-off-by: Madhav Kandukuri <[email protected]>
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 14, 2025
@madhav165
Start alembic revision history (IBM#240)
2b665a8 
* Alembic bootstrap with alembic_version table
Signed-off-by: Madhav Kandukuri <[email protected]>

* Remove migration dependence
Signed-off-by: Madhav Kandukuri <[email protected]>
vk-playground pushed a commit to vk-playground/mcp-context-forge that referenced this pull request Sep 16, 2025
@madhav165
Start alembic revision history (IBM#240)
6310a37 
* Alembic bootstrap with alembic_version table
Signed-off-by: Madhav Kandukuri <[email protected]>

* Remove migration dependence
Signed-off-by: Madhav Kandukuri <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@crivetimihai crivetimihai crivetimihai approved these changes

Assignees

@madhav165 madhav165

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@madhav165 @crivetimihai