simpler linter

Author: Zac-HD

hypothesis-python/tests/cover/test_compat.py

@@ -150,7 +150,7 @@ def test_extract_bits_roundtrip(width, x):
     assert x == sum(v << p for p, v in enumerate(reversed(bits)))
 
 
-@dataclass(frozen=True)
+@dataclass(frozen=True, slots=False)
 class ImmutableError:
     msg: str
 

hypothesis-python/tests/cover/test_lookup_py38.py

@@ -120,7 +120,7 @@ def test_layered_optional_key_is_optional():
     find_any(from_type(C), lambda d: "b" not in d)
 
 
-@dataclasses.dataclass()
+@dataclasses.dataclass(slots=False, frozen=False)
 class Node:
     left: typing.Union["Node", int]
     right: typing.Union["Node", int]

tooling/src/hypothesistooling/__main__.py

@@ -82,6 +82,20 @@ def lint():
     pip_tool("ruff", "check", ".")
     codespell(*(p for p in tools.all_files() if not p.name.endswith("by-domain.txt")))
 
+    matches = subprocess.run(
+        r"git grep -En '@(dataclasses\.)?dataclass\(.*\)' "
+        "| grep -Ev 'frozen=.*slots=|slots=.*frozen='",
+        shell=True,
+        capture_output=True,
+        text=True,
+    ).stdout
+    if matches:
+        from textwrap import indent
+
+        print("\nAll dataclass decorators must pass slots= and frozen= arguments:")
+        print(indent(matches, "    "))
+        sys.exit(1)
+
 
 def do_release(package):
     if not package.has_release():