Skip to content

feat: PDFをダウンロードするAPIの型 #60

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
m-haketa opened this issue Sep 18, 2021 · 0 comments · Fixed by #63
Closed

feat: PDFをダウンロードするAPIの型 #60

m-haketa opened this issue Sep 18, 2021 · 0 comments · Fixed by #63

Comments

@m-haketa
Copy link

freeeAPIスキーマ
https://raw.githubusercontent.com/freee/freee-api-schema/master/v2020_06_15/open-api-3/api-schema.yml
の下記の箇所

paths:
  "/api/1/journals/reports/{id}/download"
    get:
      responses:
        '200':
          content:
            application/pdf:
              schema:
                format: binary
                type: string

他、

          content:
            image/*:
              schema:
                format: binary
                type: string

というパターンもあります。

The current behavior

返り値の型が「string」になる

The expected behavior

blobなどbinary系の型を付ける

なお、実際にどの型を付けるべきかは、ユーザ側の環境依存で変わる可能性が高いので、ユーザ側で付ける型を変えられれば理想的だと思います

@m-haketa m-haketa added the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Sep 18, 2021
@Himenon Himenon removed the Status: Unconfirmed A potential issue that we haven't yet confirmed as a bug label Nov 9, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants