Resolves ggml-org#3878 by enforcing existence of root node before returning valid grammar structure.

HanClinto · HanClinto · commit bfcf545d5b2d · 2024-03-11T17:41:57.000-04:00
diff --git a/common/grammar-parser.cpp b/common/grammar-parser.cpp
@@ -294,6 +294,10 @@ namespace grammar_parser {
                     }
                 }
             }
+            // Ensure that the "root" node is defined
+            if (state.symbol_ids.find("root") == state.symbol_ids.end()) {
+                throw std::runtime_error("Undefined rule identifier 'root'");
+            }
             return state;
         } catch (const std::exception & err) {
             fprintf(stderr, "%s: error parsing grammar: %s\n", __func__, err.what());

Original file line number	Diff line number	Diff line change
`@@ -294,6 +294,10 @@ namespace grammar_parser {`
`294`	`294`	`}`
`295`	`295`	`}`
`296`	`296`	`}`
	`297`	`+ // Ensure that the "root" node is defined`
	`298`	`+ if (state.symbol_ids.find("root") == state.symbol_ids.end()) {`
	`299`	`+ throw std::runtime_error("Undefined rule identifier 'root'");`
	`300`	`+ }`
`297`	`301`	`return state;`
`298`	`302`	`} catch (const std::exception & err) {`
`299`	`303`	`fprintf(stderr, "%s: error parsing grammar: %s\n", __func__, err.what());`