Skip to content

Conversation

@lujamitch
Copy link
Contributor

@lujamitch lujamitch commented Jun 24, 2025

inference_accelerator attribute + argument for aws_ecs_task_definition was removed in recent AWS provider upgrade to v6. see here

In this PR:

  • Removed inference accelerator from core/service and core/task
  • Update examples to AWS provider v6 and Terraform 1.5.7 (mainly to make pre-commit happy)
  • Update documentation

This PR only intends to make the module forward compatible with 6.0, this is not an upgrade to 6.0

Resolves #40

@lujamitch lujamitch requested a review from a team June 24, 2025 08:04
@lujamitch lujamitch self-assigned this Jun 24, 2025
@lujamitch lujamitch marked this pull request as ready for review June 24, 2025 08:05
@lujamitch lujamitch closed this Jun 24, 2025
@lujamitch
Copy link
Contributor Author

The recent upgrade to the aws_provider has broke some of the examples.

The asg module currently has a PR open to fix this.

The vpc module has enforced >=6.0, so maybe for examples we will have to use 6.0 in order to pass the pre-commit, and the Terraform to be valid.

@lujamitch lujamitch reopened this Jun 24, 2025
@FurqanHabibi
Copy link
Contributor

Thank you for working on this!

so maybe for examples we will have to use 6.0 in order to pass the pre-commit, and the Terraform to be valid.

I agree with you. Let's bump-up to v6 on the examples!

@michaelaw320
Copy link
Collaborator

Tests are failing, can you take a look at what terraform validate is not happy with?

@lujamitch
Copy link
Contributor Author

lujamitch commented Jun 27, 2025

Tests are failing, can you take a look at what terraform validate is not happy with?

@michaelaw320
Need to up Terraform version for the examples to support the new versions of the modules, then it should be ok.

Copy link
Contributor

@hanscg hanscg left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

@lujamitch lujamitch requested a review from FurqanHabibi July 1, 2025 07:47
Copy link
Contributor

@FurqanHabibi FurqanHabibi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you 🙏

@lujamitch lujamitch merged commit 8b9968f into main Jul 1, 2025
25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Support AWS provider v6

5 participants