-
Notifications
You must be signed in to change notification settings - Fork 23
Remove inference accelerator input to be forward compatible with AWS provider v6
#41
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thank you for working on this!
I agree with you. Let's bump-up to v6 on the examples! |
|
Tests are failing, can you take a look at what terraform validate is not happy with? |
@michaelaw320 |
hanscg
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks!
FurqanHabibi
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you 🙏
inference_acceleratorattribute + argument foraws_ecs_task_definitionwas removed in recent AWS provider upgrade tov6. see hereIn this PR:
inference acceleratorfromcore/serviceandcore/task1.5.7(mainly to make pre-commit happy)This PR only intends to make the module forward compatible with
6.0, this is not an upgrade to6.0Resolves #40