Skip to content

Commit 95f8671

Browse files
author
Gusted
committed
Mark TemplateLoading error as "UnprocessableEntity" (go-gitea#19445)
- Backport go-gitea#19445 - Don't return Internal Server error if the user provide incorrect label template, instead return UnprocessableEntity. - Resolves go-gitea#19399
1 parent 6bddfd3 commit 95f8671

File tree

1 file changed

+6
-4
lines changed

1 file changed

+6
-4
lines changed

routers/api/v1/repo/repo.go

Lines changed: 6 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -21,6 +21,7 @@ import (
2121
"code.gitea.io/gitea/modules/convert"
2222
"code.gitea.io/gitea/modules/git"
2323
"code.gitea.io/gitea/modules/log"
24+
repo_module "code.gitea.io/gitea/modules/repository"
2425
"code.gitea.io/gitea/modules/setting"
2526
api "code.gitea.io/gitea/modules/structs"
2627
"code.gitea.io/gitea/modules/util"
@@ -160,7 +161,7 @@ func Search(ctx *context.APIContext) {
160161
opts.Collaborate = util.OptionalBoolFalse
161162
}
162163

163-
var mode = ctx.FormString("mode")
164+
mode := ctx.FormString("mode")
164165
switch mode {
165166
case "source":
166167
opts.Fork = util.OptionalBoolFalse
@@ -186,9 +187,9 @@ func Search(ctx *context.APIContext) {
186187
opts.IsPrivate = util.OptionalBoolOf(ctx.FormBool("is_private"))
187188
}
188189

189-
var sortMode = ctx.FormString("sort")
190+
sortMode := ctx.FormString("sort")
190191
if len(sortMode) > 0 {
191-
var sortOrder = ctx.FormString("order")
192+
sortOrder := ctx.FormString("order")
192193
if len(sortOrder) == 0 {
193194
sortOrder = "asc"
194195
}
@@ -264,7 +265,8 @@ func CreateUserRepo(ctx *context.APIContext, owner *user_model.User, opt api.Cre
264265
if repo_model.IsErrRepoAlreadyExist(err) {
265266
ctx.Error(http.StatusConflict, "", "The repository with the same name already exists.")
266267
} else if db.IsErrNameReserved(err) ||
267-
db.IsErrNamePatternNotAllowed(err) {
268+
db.IsErrNamePatternNotAllowed(err) ||
269+
repo_module.IsErrIssueLabelTemplateLoad(err) {
268270
ctx.Error(http.StatusUnprocessableEntity, "", err)
269271
} else {
270272
ctx.Error(http.StatusInternalServerError, "CreateRepository", err)

0 commit comments

Comments
 (0)