From db7515c94477c490f42af87077ad0cda49cea69c Mon Sep 17 00:00:00 2001
From: Max Fisher <maxmfishernj@gmail.com>
Date: Wed, 29 Dec 2021 17:50:36 -0800
Subject: [PATCH 1/5] better decimal rounding in NumberInput

---
 .../components/widgets/inputs/NumberInput.vue | 22 +++++++++++--------
 1 file changed, 13 insertions(+), 9 deletions(-)

diff --git a/frontend/src/components/widgets/inputs/NumberInput.vue b/frontend/src/components/widgets/inputs/NumberInput.vue
index d3cca9ee25..ea97998b81 100644
--- a/frontend/src/components/widgets/inputs/NumberInput.vue
+++ b/frontend/src/components/widgets/inputs/NumberInput.vue
@@ -151,6 +151,7 @@
 
 <script lang="ts">
 import { defineComponent, PropType } from "vue";
+import { clamp } from "@/utilities/math";
 
 export enum IncrementBehavior {
 	Add = "Add",
@@ -168,8 +169,8 @@ export default defineComponent({
 	components: {},
 	props: {
 		value: { type: Number, required: true },
-		min: { type: Number, required: false },
-		max: { type: Number, required: false },
+		min: { type: Number, default: -Infinity },
+		max: { type: Number, default: Infinity },
 		incrementBehavior: { type: String as PropType<IncrementBehavior>, default: IncrementBehavior.Add },
 		incrementFactor: { type: Number, default: 1 },
 		incrementCallbackIncrease: { type: Function, required: false },
@@ -251,12 +252,14 @@ export default defineComponent({
 			if (invalid) sanitized = this.value;
 
 			if (this.isInteger) sanitized = Math.round(sanitized);
-			if (typeof this.min === "number" && !Number.isNaN(this.min)) sanitized = Math.max(sanitized, this.min);
-			if (typeof this.max === "number" && !Number.isNaN(this.max)) sanitized = Math.min(sanitized, this.max);
+			sanitized = clamp(newValue, this.min, this.max);
 
 			if (!invalid) this.$emit("update:value", sanitized);
 
-			const roundingPower = 10 ** this.displayDecimalPlaces;
+			const leftSideStringNum = sanitized.toString().split(".")[0];
+			// If the only left side digit is a zero it should not count towards rounding power
+			const leftSideDigits = leftSideStringNum.length === 1 && leftSideStringNum[0] === "0" ? 0 : leftSideStringNum.length;
+			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);
 			const displayValue = Math.round(sanitized * roundingPower) / roundingPower;
 			this.text = `${displayValue}${this.unit}`;
 		},
@@ -269,11 +272,12 @@ export default defineComponent({
 				return;
 			}
 
-			let sanitized = newValue;
-			if (typeof this.min === "number") sanitized = Math.max(sanitized, this.min);
-			if (typeof this.max === "number") sanitized = Math.min(sanitized, this.max);
+			const sanitized = clamp(newValue, this.min, this.max);
 
-			const roundingPower = 10 ** this.displayDecimalPlaces;
+			const leftSideStringNum = sanitized.toString().split(".")[0];
+			// If the only left side digit is a zero it should not count towards rounding power
+			const leftSideDigits = leftSideStringNum.length === 1 && leftSideStringNum[0] === "0" ? 0 : leftSideStringNum.length;
+			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);
 			const displayValue = Math.round(sanitized * roundingPower) / roundingPower;
 			this.text = `${displayValue}${this.unit}`;
 		},

From b0b0c587381da92b34f8c130258d0d333ce75008 Mon Sep 17 00:00:00 2001
From: Max Fisher <maxmfishernj@gmail.com>
Date: Sun, 2 Jan 2022 20:55:02 -0800
Subject: [PATCH 2/5] - created function to reuse - used math instead of string
 manipulation

---
 .../components/widgets/inputs/NumberInput.vue | 21 ++++++++++---------
 1 file changed, 11 insertions(+), 10 deletions(-)

diff --git a/frontend/src/components/widgets/inputs/NumberInput.vue b/frontend/src/components/widgets/inputs/NumberInput.vue
index 9d6484d382..1f3a4a439f 100644
--- a/frontend/src/components/widgets/inputs/NumberInput.vue
+++ b/frontend/src/components/widgets/inputs/NumberInput.vue
@@ -246,11 +246,17 @@ export default defineComponent({
 
 			if (!invalid) this.$emit("update:value", sanitized);
 
-			const leftSideStringNum = sanitized.toString().split(".")[0];
-			// If the only left side digit is a zero it should not count towards rounding power
-			const leftSideDigits = leftSideStringNum.length === 1 && leftSideStringNum[0] === "0" ? 0 : leftSideStringNum.length;
+			this.setText(sanitized);
+		},
+		setText(value: number) {
+			// Find the amount of digits on the left side of the number
+			// 10.25 == 2
+			// 1.23 == 3
+			// 0.23 == 0 - Reason for the slightly more complicated code
+			const leftSideDigits = Math.max(Math.floor(value).toString().length, 0) * Math.sign(value);
+
 			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);
-			const displayValue = Math.round(sanitized * roundingPower) / roundingPower;
+			const displayValue = Math.round(value * roundingPower) / roundingPower;
 			this.text = `${displayValue}${this.unit}`;
 		},
 	},
@@ -264,12 +270,7 @@ export default defineComponent({
 
 			const sanitized = clamp(newValue, this.min, this.max);
 
-			const leftSideStringNum = sanitized.toString().split(".")[0];
-			// If the only left side digit is a zero it should not count towards rounding power
-			const leftSideDigits = leftSideStringNum.length === 1 && leftSideStringNum[0] === "0" ? 0 : leftSideStringNum.length;
-			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);
-			const displayValue = Math.round(sanitized * roundingPower) / roundingPower;
-			this.text = `${displayValue}${this.unit}`;
+			this.setText(sanitized);
 		},
 	},
 	mounted() {

From a09555d1cd5b8213882d54256e60f294cca0041b Mon Sep 17 00:00:00 2001
From: mfish33 <maxmfishernj@gmail.com>
Date: Mon, 3 Jan 2022 11:09:01 -0800
Subject: [PATCH 3/5] updated comment to be correct

---
 frontend/src/components/widgets/inputs/NumberInput.vue | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/frontend/src/components/widgets/inputs/NumberInput.vue b/frontend/src/components/widgets/inputs/NumberInput.vue
index 1f3a4a439f..1d47682669 100644
--- a/frontend/src/components/widgets/inputs/NumberInput.vue
+++ b/frontend/src/components/widgets/inputs/NumberInput.vue
@@ -251,7 +251,7 @@ export default defineComponent({
 		setText(value: number) {
 			// Find the amount of digits on the left side of the number
 			// 10.25 == 2
-			// 1.23 == 3
+			// 1.23 == 1
 			// 0.23 == 0 - Reason for the slightly more complicated code
 			const leftSideDigits = Math.max(Math.floor(value).toString().length, 0) * Math.sign(value);
 

From 67489bb37b1c659a42a4e7ab9ea19e7df5b34208 Mon Sep 17 00:00:00 2001
From: mfish33 <maxmfishernj@gmail.com>
Date: Thu, 6 Jan 2022 15:03:50 -0800
Subject: [PATCH 4/5] updated comment

---
 frontend/src/components/widgets/inputs/NumberInput.vue | 6 +++---
 1 file changed, 3 insertions(+), 3 deletions(-)

diff --git a/frontend/src/components/widgets/inputs/NumberInput.vue b/frontend/src/components/widgets/inputs/NumberInput.vue
index 1d47682669..5a1507e40c 100644
--- a/frontend/src/components/widgets/inputs/NumberInput.vue
+++ b/frontend/src/components/widgets/inputs/NumberInput.vue
@@ -250,9 +250,9 @@ export default defineComponent({
 		},
 		setText(value: number) {
 			// Find the amount of digits on the left side of the number
-			// 10.25 == 2
-			// 1.23 == 1
-			// 0.23 == 0 - Reason for the slightly more complicated code
+			// 10.25 == 2 left side of Decimal
+			// 1.23 == 1 left side of Decimal
+			// 0.23 == 0 left side of Decimal - Reason for the slightly more complicated code
 			const leftSideDigits = Math.max(Math.floor(value).toString().length, 0) * Math.sign(value);
 
 			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);

From 7271a76f05cd1388a66df5ae663c019d45bb0afa Mon Sep 17 00:00:00 2001
From: mfish33 <maxmfishernj@gmail.com>
Date: Thu, 6 Jan 2022 16:57:47 -0800
Subject: [PATCH 5/5] updated comment

---
 frontend/src/components/widgets/inputs/NumberInput.vue | 8 ++++----
 1 file changed, 4 insertions(+), 4 deletions(-)

diff --git a/frontend/src/components/widgets/inputs/NumberInput.vue b/frontend/src/components/widgets/inputs/NumberInput.vue
index 5a1507e40c..6f8c1ca75c 100644
--- a/frontend/src/components/widgets/inputs/NumberInput.vue
+++ b/frontend/src/components/widgets/inputs/NumberInput.vue
@@ -249,10 +249,10 @@ export default defineComponent({
 			this.setText(sanitized);
 		},
 		setText(value: number) {
-			// Find the amount of digits on the left side of the number
-			// 10.25 == 2 left side of Decimal
-			// 1.23 == 1 left side of Decimal
-			// 0.23 == 0 left side of Decimal - Reason for the slightly more complicated code
+			// Find the amount of digits on the left side of the Decimal
+			// 10.25 == 2
+			// 1.23 == 1
+			// 0.23 == 0 - Reason for the slightly more complicated code
 			const leftSideDigits = Math.max(Math.floor(value).toString().length, 0) * Math.sign(value);
 
 			const roundingPower = 10 ** Math.max(this.displayDecimalPlaces - leftSideDigits, 0);