-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Add extraction feature #2419
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add extraction feature #2419
Conversation
Summary of ChangesHello @arieljassan, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the Highlights
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable new feature for document classification and entity extraction using Gemini. The overall structure is sound, with a clear separation of concerns between the web server, processing logic, and utilities. My feedback primarily focuses on improving logging practices for better monitoring, enhancing the robustness of configuration loading, and ensuring full adherence to the repository's style guide, particularly in the documentation and SDK usage. These changes will improve the maintainability and reliability of the new service.
|
Warning Gemini encountered an error creating the review. You can try again by commenting |
|
@arieljassan Can you do a rebase on this branch? It's currently showing all of the commits without the ones pulled from main. |
check-spelling run (pull_request) for add-extraction-feature Signed-off-by: check-spelling-bot <[email protected]> on-behalf-of: @check-spelling <[email protected]>
530d017 to
a14c33a
Compare
Add document classification feature before entity extraction.