Skip to content

Commit 464c84e

Browse files
author
Kenneth Rosario
authored
chore: make buildpack integ test run on pull request (#553)
1 parent 5355069 commit 464c84e

File tree

3 files changed

+20
-7
lines changed

3 files changed

+20
-7
lines changed

.github/workflows/buildpack-integration-test.yml

Lines changed: 16 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -4,63 +4,73 @@ on:
44
push:
55
branches:
66
- master
7+
pull_request:
8+
# Runs every day on 12:00 AM PST
9+
schedule:
10+
- cron: "0 0 * * *"
711
workflow_dispatch:
812

913
# Declare default permissions as read only.
1014
permissions: read-all
1115

1216
jobs:
1317
nodejs10:
14-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
18+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
1519
with:
1620
http-builder-source: 'test/conformance'
1721
http-builder-target: 'writeHttpDeclarative'
1822
cloudevent-builder-source: 'test/conformance'
1923
cloudevent-builder-target: 'writeCloudEventDeclarative'
2024
prerun: 'test/conformance/prerun.sh'
2125
builder-runtime: 'nodejs10'
26+
builder-runtime-version: '10'
2227
nodejs12:
23-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
28+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
2429
with:
2530
http-builder-source: 'test/conformance'
2631
http-builder-target: 'writeHttpDeclarative'
2732
cloudevent-builder-source: 'test/conformance'
2833
cloudevent-builder-target: 'writeCloudEventDeclarative'
2934
prerun: 'test/conformance/prerun.sh'
3035
builder-runtime: 'nodejs12'
36+
builder-runtime-version: '12'
3137
nodejs14:
32-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
38+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
3339
with:
3440
http-builder-source: 'test/conformance'
3541
http-builder-target: 'writeHttpDeclarative'
3642
cloudevent-builder-source: 'test/conformance'
3743
cloudevent-builder-target: 'writeCloudEventDeclarative'
3844
prerun: 'test/conformance/prerun.sh'
3945
builder-runtime: 'nodejs14'
46+
builder-runtime-version: '14'
4047
nodejs16:
41-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
48+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
4249
with:
4350
http-builder-source: 'test/conformance'
4451
http-builder-target: 'writeHttpDeclarative'
4552
cloudevent-builder-source: 'test/conformance'
4653
cloudevent-builder-target: 'writeCloudEventDeclarative'
4754
prerun: 'test/conformance/prerun.sh'
4855
builder-runtime: 'nodejs16'
56+
builder-runtime-version: '16'
4957
nodejs18:
50-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
58+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
5159
with:
5260
http-builder-source: 'test/conformance'
5361
http-builder-target: 'writeHttpDeclarative'
5462
cloudevent-builder-source: 'test/conformance'
5563
cloudevent-builder-target: 'writeCloudEventDeclarative'
5664
prerun: 'test/conformance/prerun.sh'
5765
builder-runtime: 'nodejs18'
66+
builder-runtime-version: '18'
5867
nodejs20:
59-
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].3
68+
uses: GoogleCloudPlatform/functions-framework-conformance/.github/workflows/[email protected].4
6069
with:
6170
http-builder-source: 'test/conformance'
6271
http-builder-target: 'writeHttpDeclarative'
6372
cloudevent-builder-source: 'test/conformance'
6473
cloudevent-builder-target: 'writeCloudEventDeclarative'
6574
prerun: 'test/conformance/prerun.sh'
6675
builder-runtime: 'nodejs20'
76+
builder-runtime-version: '20'

.github/workflows/conformance.yml

Lines changed: 2 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1,6 +1,8 @@
11
name: Node.js Conformance CI
22
on:
33
push:
4+
branches:
5+
- master
46
pull_request:
57

68
# Declare default permissions as read only.

test/conformance/prerun.sh

Lines changed: 2 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,4 +18,5 @@ npm pack --pack-destination $SCRIPT_DIR
1818
cd $SCRIPT_DIR
1919

2020
npm install google-cloud-functions-framework-0.0.0.tgz
21-
cat package.json
21+
rm package-lock.json
22+
cat package.json

0 commit comments

Comments
 (0)