-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add support for akera ASR model #788
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Changes from 1 commit
Commits
Show all changes
2 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Verification agent
🧩 Analysis chain
Akera branch drops
task: translation requests will be silently ignored.Because you
pop("task"), any non-emptyspeech_translation_targetis effectively ignored for Akera. If that’s intentional (Akera doesn’t support ST), either:Also, prefer safe pop and explicit enum match to avoid brittle substring checks.
Minimal guard + safer pop:
If you prefer a fallback rather than an error, I can wire
run_translate(...)post-ASR and document that SRT/VTT won’t be available for the translated text without time-aligned chunks.I can add a small unit test that asserts: (a) no
task/languageis sent for Akera, (b) translation requests raiseUserError. Want me to open a test PR?🏁 Script executed:
Length of output: 10493
🏁 Script executed:
Length of output: 2075
🏁 Script executed:
Length of output: 15273
🏁 Script executed:
Length of output: 756
Guard Akera model translation support and use explicit enum match
Akera’s branch currently drops
taskwithout notifying whenspeech_translation_targetis set, silently ignoring translation requests.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
yes, i would prefer
kwargs.pop("task", None)tooThere was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@devxpy Perfect! Using
kwargs.pop("task", None)is definitely the safer approach. It prevents potential KeyError exceptions if the "task" key somehow doesn't exist in the kwargs dictionary, making the code more robust through defensive programming.This small change improves the reliability of the Akera model handling while maintaining the same functionality. Good call on preferring the defensive approach!
🐰 ✨