thanks clippy

Of Rust 1.54

Author: Byron

experiments/hash-owned-borrowed/src/lib.rs

@@ -38,7 +38,7 @@ impl AsRef<Borrowed> for Owned {
     fn as_ref(&self) -> &Borrowed {
         match self {
             Owned::Sha1(b) => Borrowed::from_bytes(b.as_ref()),
-            Owned::Sha256(b) => Borrowed::from_bytes(&b.as_ref()),
+            Owned::Sha256(b) => Borrowed::from_bytes(b.as_ref()),
         }
     }
 }

experiments/traversal/src/main.rs

@@ -53,7 +53,7 @@ fn main() -> anyhow::Result<()> {
         let start = Instant::now();
         let (unique, entries) = do_gitoxide_tree_dag_traversal(
             &all_commits,
-            &db,
+            db,
             odb::pack::cache::lru::StaticLinkedList::<64>::default,
             *compute_mode,
         )?;
@@ -85,7 +85,7 @@ fn main() -> anyhow::Result<()> {
     );
 
     let start = Instant::now();
-    let count = do_gitoxide_commit_graph_traversal(commit_id, &db, || {
+    let count = do_gitoxide_commit_graph_traversal(commit_id, db, || {
         odb::pack::cache::lru::MemoryCappedHashmap::new(GITOXIDE_CACHED_OBJECT_DATA_PER_THREAD_IN_BYTES)
     })?;
     let elapsed = start.elapsed();
@@ -101,7 +101,7 @@ fn main() -> anyhow::Result<()> {
     let start = Instant::now();
     let count = do_gitoxide_commit_graph_traversal(
         commit_id,
-        &db,
+        db,
         odb::pack::cache::lru::StaticLinkedList::<GITOXIDE_STATIC_CACHE_SIZE>::default,
     )?;
     let elapsed = start.elapsed();
@@ -115,7 +115,7 @@ fn main() -> anyhow::Result<()> {
     );
 
     let start = Instant::now();
-    let count = do_gitoxide_commit_graph_traversal(commit_id, &db, || odb::pack::cache::Never)?;
+    let count = do_gitoxide_commit_graph_traversal(commit_id, db, || odb::pack::cache::Never)?;
     let elapsed = start.elapsed();
     let objs_per_sec = |elapsed: Duration| count as f32 / elapsed.as_secs_f32();
     println!(
@@ -267,10 +267,7 @@ where
                         let seen = &seen;
                         move || {
                             (
-                                Count {
-                                    entries: 0,
-                                    seen: &seen,
-                                },
+                                Count { entries: 0, seen },
                                 Vec::<u8>::new(),
                                 Vec::<u8>::new(),
                                 new_cache(),

git-commitgraph/src/file/access.rs

@@ -85,7 +85,7 @@ impl File {
             let mid_sha = self.id_at(file::Position(mid));
 
             use std::cmp::Ordering::*;
-            match id.cmp(&mid_sha) {
+            match id.cmp(mid_sha) {
                 Less => upper_bound = mid,
                 Equal => return Some(file::Position(mid)),
                 Greater => lower_bound = mid + 1,

git-config/src/file.rs

@@ -1030,7 +1030,7 @@ impl<'lookup, 'event> MutableMultiValue<'_, 'lookup, 'event> {
     /// This will panic if the index is out of range.
     #[inline]
     pub fn set_string(&mut self, index: usize, input: String) {
-        self.set_bytes(index, input.into_bytes())
+        self.set_bytes(index, input.into_bytes());
     }
 
     /// Sets the value at the given index.
@@ -1040,7 +1040,7 @@ impl<'lookup, 'event> MutableMultiValue<'_, 'lookup, 'event> {
     /// This will panic if the index is out of range.
     #[inline]
     pub fn set_bytes(&mut self, index: usize, input: Vec<u8>) {
-        self.set_value(index, Cow::Owned(input))
+        self.set_value(index, Cow::Owned(input));
     }
 
     /// Sets the value at the given index.
@@ -1099,7 +1099,7 @@ impl<'lookup, 'event> MutableMultiValue<'_, 'lookup, 'event> {
     /// input for all values.
     #[inline]
     pub fn set_str_all(&mut self, input: &str) {
-        self.set_owned_values_all(input.as_bytes())
+        self.set_owned_values_all(input.as_bytes());
     }
 
     /// Sets all values in this multivar to the provided one by copying the
@@ -1721,7 +1721,7 @@ impl<'event> GitConfig<'event> {
                 }
             }
             if !found_node {
-                lookup.push(LookupTreeNode::Terminal(vec![new_section_id]))
+                lookup.push(LookupTreeNode::Terminal(vec![new_section_id]));
             }
         }
         self.section_order.push_back(new_section_id);

git-hash/src/owned.rs

@@ -70,7 +70,7 @@ impl ObjectId {
     /// Panics if this instance is not a sha1 hash.
     pub fn sha1(&self) -> &[u8; SIZE_OF_SHA1_DIGEST] {
         match self {
-            Self::Sha1(b) => &b,
+            Self::Sha1(b) => b,
         }
     }
 

git-object/src/immutable/commit/decode.rs

@@ -26,7 +26,7 @@ pub fn message<'a, E: ParseError<&'a [u8]> + ContextError<&'a [u8]>>(i: &'a [u8]
         )));
     }
     let (i, _) = context("a newline separates headers from the message", tag(NL))(i)?;
-    Ok((&[], &i.as_bstr()))
+    Ok((&[], i.as_bstr()))
 }
 
 pub fn commit<'a, E: ParseError<&'a [u8]> + ContextError<&'a [u8]>>(i: &'a [u8]) -> IResult<&'a [u8], Commit<'_>, E> {

git-object/src/immutable/tag.rs

@@ -98,7 +98,7 @@ mod decode {
             }
             // an empty signature message signals that there is none - the function signature is needed
             // to work with 'alt(…)'. PGP signatures are never empty
-            Ok((&[], (&i, &[])))
+            Ok((&[], (i, &[])))
         }
         let (i, (message, signature)) = alt((
             tuple((

git-object/src/mutable/convert.rs

@@ -11,7 +11,7 @@ impl From<immutable::Tag<'_>> for mutable::Tag {
             pgp_signature,
         } = other;
         mutable::Tag {
-            target: git_hash::ObjectId::from_hex(&target).expect("40 bytes hex sha1"),
+            target: git_hash::ObjectId::from_hex(target).expect("40 bytes hex sha1"),
             name: name.to_owned(),
             target_kind,
             message: message.to_owned(),
@@ -33,7 +33,7 @@ impl From<immutable::Commit<'_>> for mutable::Commit {
             extra_headers,
         } = other;
         mutable::Commit {
-            tree: git_hash::ObjectId::from_hex(&tree).expect("40 bytes hex sha1"),
+            tree: git_hash::ObjectId::from_hex(tree).expect("40 bytes hex sha1"),
             parents: parents
                 .iter()
                 .map(|parent| git_hash::ObjectId::from_hex(parent).expect("40 bytes hex sha1"))

git-object/src/mutable/tag.rs

@@ -58,7 +58,7 @@ impl Tag {
         }
         if let Some(ref message) = self.pgp_signature {
             out.write_all(NL)?;
-            out.write_all(&message)?;
+            out.write_all(message)?;
         }
         Ok(())
     }

git-object/src/mutable/tree.rs

@@ -90,7 +90,7 @@ impl Tree {
             if filename.find_byte(b'\n').is_some() {
                 return Err(Error::NewlineInFilename(filename.to_owned()).into());
             }
-            out.write_all(&filename)?;
+            out.write_all(filename)?;
             out.write_all(&[b'\0'])?;
 
             out.write_all(oid.as_bytes())?;

git-object/src/types.rs

@@ -17,7 +17,7 @@ quick_error! {
     #[allow(missing_docs)]
     pub enum Error {
         InvalidObjectKind(kind: crate::BString) {
-            display("Unknown object kind: {:?}", std::str::from_utf8(&kind))
+            display("Unknown object kind: {:?}", std::str::from_utf8(kind))
         }
     }
 }

git-odb/src/alternate/parse.rs

@@ -6,7 +6,7 @@ use std::{borrow::Cow, path::PathBuf};
 #[derive(thiserror::Error, Debug)]
 #[allow(missing_docs)]
 pub enum Error {
-    #[error("Could not obtain an object path for the alternate directory '{}'", String::from_utf8_lossy(&.0))]
+    #[error("Could not obtain an object path for the alternate directory '{}'", String::from_utf8_lossy(.0))]
     PathConversion(Vec<u8>),
     #[error("Could not unquote alternate path")]
     Unquote(#[from] unquote::Error),

git-odb/src/alternate/unquote.rs

@@ -4,9 +4,9 @@ use std::io::Read;
 
 #[derive(thiserror::Error, Debug)]
 pub enum Error {
-    #[error("{message}: {:?}", String::from_utf8_lossy(&.input))]
+    #[error("{message}: {:?}", String::from_utf8_lossy(.input))]
     InvalidInput { message: String, input: Vec<u8> },
-    #[error("Invalid escaped value {byte} in input {:?}", String::from_utf8_lossy(&.input))]
+    #[error("Invalid escaped value {byte} in input {:?}", String::from_utf8_lossy(.input))]
     UnsupportedEscapeByte { byte: u8, input: Vec<u8> },
 }
 

git-odb/src/store/linked/iter.rs

@@ -120,6 +120,6 @@ impl linked::Store {
     ///
     /// Useful in conjunction with `'static threads`.
     pub fn arc_iter(self: &Arc<linked::Store>) -> AllObjects<Arc<linked::Store>> {
-        AllObjects::new(Arc::clone(&self))
+        AllObjects::new(Arc::clone(self))
     }
 }

git-pack/src/bundle/write/error.rs

@@ -7,7 +7,7 @@ pub enum Error {
     #[error(transparent)]
     PackIter(#[from] crate::data::input::Error),
     #[error("Could not move a temporary file into its desired place")]
-    PeristError(#[from] tempfile::PersistError),
+    Perist(#[from] tempfile::PersistError),
     #[error(transparent)]
     IndexWrite(#[from] crate::index::write::Error),
 }

git-pack/src/data/input/entry.rs

@@ -7,7 +7,7 @@ impl input::Entry {
     /// This method is useful when arbitrary base entries are created
     pub fn from_data_obj(obj: &data::Object<'_>, pack_offset: u64) -> Result<Self, input::Error> {
         let header = to_header(obj.kind);
-        let compressed = compress_data(&obj)?;
+        let compressed = compress_data(obj)?;
         let compressed_size = compressed.len() as u64;
         let mut entry = input::Entry {
             header,

git-pack/src/data/object.rs

@@ -90,7 +90,7 @@ pub mod verify {
             let mut sink = hash::Write::new(io::sink(), desired.kind());
 
             loose::object::header::encode(self.kind, self.data.len() as u64, &mut sink).expect("hash to always work");
-            sink.hash.update(&self.data);
+            sink.hash.update(self.data);
 
             let actual_id = git_hash::ObjectId::from(sink.hash.digest());
             if desired != actual_id {

git-pack/src/data/output/count/iter_from_objects.rs

@@ -148,7 +148,7 @@ where
                                                     push_obj_count_unique(
                                                         &mut out,
                                                         seen_objs,
-                                                        &commit_id,
+                                                        commit_id,
                                                         &parent_commit_obj,
                                                         progress,
                                                         stats,
@@ -370,7 +370,7 @@ fn push_obj_count_unique(
         if count_expanded {
             statistics.expanded_objects += 1;
         }
-        out.push(output::Count::from_data(id, &obj));
+        out.push(output::Count::from_data(id, obj));
     }
 }
 
@@ -404,7 +404,7 @@ mod util {
         fn next(&mut self) -> Option<Self::Item> {
             let mut res = Vec::with_capacity(self.size);
             let mut items_left = self.size;
-            while let Some(item) = self.iter.next() {
+            for item in &mut self.iter {
                 res.push(item);
                 items_left -= 1;
                 if items_left == 0 {

git-pack/src/index/access.rs

@@ -137,7 +137,7 @@ impl index::File {
             let mid_sha = self.oid_at_index(mid);
 
             use std::cmp::Ordering::*;
-            match id.cmp(&mid_sha) {
+            match id.cmp(mid_sha) {
                 Less => upper_bound = mid,
                 Equal => return Some(mid),
                 Greater => lower_bound = mid + 1,

git-pack/src/index/traverse/mod.rs

@@ -189,7 +189,7 @@ impl index::File {
         process_entry(
             check,
             object_kind,
-            &buf,
+            buf,
             progress,
             header_buf,
             index_entry,
@@ -244,5 +244,5 @@ where
             }
         }
     }
-    processor(object_kind, decompressed, &index_entry, progress).map_err(Error::Processor)
+    processor(object_kind, decompressed, index_entry, progress).map_err(Error::Processor)
 }

git-pack/src/index/traverse/reduce.rs

@@ -46,7 +46,7 @@ where
             ..Default::default()
         };
         Reducer {
-            progress: &progress,
+            progress,
             check,
             then: Instant::now(),
             entries_seen: 0,

git-pack/src/index/write/mod.rs

@@ -231,6 +231,6 @@ fn modify_base(
     }
 
     let object_kind = pack_entry.header.as_kind().expect("base object as source of iteration");
-    let id = compute_hash(object_kind, &decompressed, hash);
+    let id = compute_hash(object_kind, decompressed, hash);
     entry.id = id;
 }

git-pack/src/lib.rs

@@ -19,8 +19,8 @@ pub use crate::bundle::Bundle;
 
 ///
 pub mod find;
-pub use find::{Find, FindExt};
 #[doc(inline)]
+pub use find::{Find, FindExt};
 
 ///
 pub mod cache;

git-pack/src/tree/traverse/resolve.rs

@@ -103,7 +103,7 @@ fn decompress_all_at_once(b: &[u8], decompressed_len: usize) -> Result<Vec<u8>,
     let mut out = Vec::new();
     out.resize(decompressed_len, 0);
     zlib::Inflate::default()
-        .once(&b, &mut out)
+        .once(b, &mut out)
         .map_err(|err| Error::ZlibInflate {
             source: err,
             message: "Failed to decompress entry",

git-packetline/src/read/async_io.rs

@@ -102,7 +102,7 @@ where
             let (is_done, stopped_at, res) = Self::read_line_inner_exhaustive(
                 &mut self.read,
                 &mut self.buf,
-                &self.delimiters,
+                self.delimiters,
                 self.fail_on_err_lines,
                 false,
             )
@@ -125,7 +125,7 @@ where
             let (is_done, stopped_at, res) = Self::read_line_inner_exhaustive(
                 &mut self.read,
                 &mut self.peek_buf,
-                &self.delimiters,
+                self.delimiters,
                 self.fail_on_err_lines,
                 true,
             )

git-packetline/src/read/blocking_io.rs

@@ -96,7 +96,7 @@ where
             let (is_done, stopped_at, res) = Self::read_line_inner_exhaustive(
                 &mut self.read,
                 &mut self.buf,
-                &self.delimiters,
+                self.delimiters,
                 self.fail_on_err_lines,
                 false,
             );
@@ -118,7 +118,7 @@ where
             let (is_done, stopped_at, res) = Self::read_line_inner_exhaustive(
                 &mut self.read,
                 &mut self.peek_buf,
-                &self.delimiters,
+                self.delimiters,
                 self.fail_on_err_lines,
                 true,
             );

git-protocol/src/fetch/arguments/mod.rs

@@ -113,7 +113,7 @@ impl Arguments {
     pub fn deepen_not(&mut self, ref_path: &BStr) {
         assert!(self.deepen_not, "'deepen-not' feature required");
         let mut line = BString::from("deepen-not ");
-        line.extend_from_slice(&ref_path);
+        line.extend_from_slice(ref_path);
         self.args.push(line);
     }
     /// Set the given filter `spec` when listing references.

git-protocol/src/fetch/response/mod.rs

@@ -196,7 +196,7 @@ impl Response {
         shallows: &mut Vec<ShallowUpdate>,
         peeked_line: &str,
     ) -> bool {
-        match Acknowledgement::from_line(&peeked_line) {
+        match Acknowledgement::from_line(peeked_line) {
             Ok(ack) => match ack.id() {
                 Some(id) => {
                     if !acks.iter().any(|a| a.id() == Some(id)) {
@@ -205,7 +205,7 @@ impl Response {
                 }
                 None => acks.push(ack),
             },
-            Err(_) => match ShallowUpdate::from_line(&peeked_line) {
+            Err(_) => match ShallowUpdate::from_line(peeked_line) {
                 Ok(shallow) => {
                     shallows.push(shallow);
                 }

git-ref/src/mutable.rs

@@ -96,7 +96,7 @@ impl Target {
     /// Interpret this owned Target as shared Target
     pub fn borrow(&self) -> crate::Target<'_> {
         match self {
-            Target::Peeled(oid) => crate::Target::Peeled(&oid),
+            Target::Peeled(oid) => crate::Target::Peeled(oid),
             Target::Symbolic(name) => crate::Target::Symbolic(name.0.as_bstr()),
         }
     }