The realization that FileBuffer really shouldn't be used anymore (#293)

Author: Byron

Cargo.lock

@@ -16,6 +16,7 @@ doctest = false
 git-hash = { version ="^0.8.0", path = "../git-hash" }
 
 quick-error = "2.0.0"
+filebuffer = "0.4.0"
 
 [dev-dependencies]
 git-testtools = { path = "../tests/tools"}

git-index/Cargo.toml

@@ -7,4 +7,5 @@ Most of the test indices are snatched directly from the unit test suite of `git`
  ./t1700-split-index.sh -r 2 --debug 
 ```
 
-Then one finds all test state and the index in particular in `trash directory/t1700-split-index/.git/index`.
+Then one finds all test state and the index in particular in `trash directory/t1700-split-index/.git/index` and can possibly copy it over and use as fixture.
+The preferred way is to find a test of interest, and use its setup code within one of our own fixture scripts that are executed once to generate the file of interest.

git-index/README.md

@@ -8,10 +8,29 @@ pub mod file {
     pub mod init {
         #![allow(unused)]
         use crate::File;
+        use filebuffer::FileBuffer;
         use std::path::Path;
 
+        mod error {
+            use quick_error::quick_error;
+
+            quick_error! {
+                #[derive(Debug)]
+                pub enum Error {
+                    Io(err: std::io::Error) {
+                        display("An IO error occurred while reading the index")
+                        source(err)
+                        from()
+                    }
+                }
+            }
+        }
+        pub use error::Error;
+
         impl File {
-            pub fn at(path: impl AsRef<Path>, object_hash: git_hash::Kind) -> std::io::Result<Self> {
+            pub fn at(path: impl AsRef<Path>, object_hash: git_hash::Kind) -> Result<Self, Error> {
+                let data = FileBuffer::open(path)?;
+
                 todo!("read file")
             }
         }

git-index/src/lib.rs

@@ -1,8 +1,11 @@
 mod init {
+    fn file(name: &str) -> git_index::File {
+        git_index::File::at(crate::index_fixture_path(name), git_hash::Kind::Sha1).unwrap()
+    }
 
     #[test]
     #[ignore]
-    fn v2() {
-        let _file = git_index::File::at(crate::index_fixture_path("v2"), git_hash::Kind::Sha1).unwrap();
+    fn read_v2() {
+        let _file = file("v2");
     }
 }