Skip to content

Commit a647598

Browse files
committed
Don't use -- argument to strip
Unlike many utilities, the `strip` utility is not required by POSIX to follow the XBD 12.2 Utility Syntax Guidelines, so need not support `--`. On macOS, and possibly some other systems, it does not, and `--` causes an error. Fortunately, it's okay to just not pass it, because the value of `$TARGET_DIR` is known not to start with `-`.
1 parent d6769a6 commit a647598

File tree

1 file changed

+1
-1
lines changed

1 file changed

+1
-1
lines changed

.github/workflows/release.yml

+1-1
Original file line numberDiff line numberDiff line change
@@ -173,7 +173,7 @@ jobs:
173173
174174
- name: Strip release binary (linux and macos)
175175
if: matrix.build == 'linux' || matrix.build == 'macos'
176-
run: strip -- "$TARGET_DIR"/release/{ein,gix}
176+
run: strip "$TARGET_DIR"/release/{ein,gix}
177177

178178
- name: Strip release binary (arm)
179179
if: matrix.build == 'linux-arm'

0 commit comments

Comments
 (0)