Skip to content

Commit 8d9296f

Browse files
committed
fix: don't use trust-dns by default when using request. (#1076)
It's reported to have issues under certain condition, please see seanmonstar/reqwest#437 for more. The `blocking-http-transport-reqwest-rust-tls-trust-dns` feature was added to provide the same feature-set as before for those who want `trust-dns`.
1 parent ea8cd0e commit 8d9296f

File tree

1 file changed

+5
-4
lines changed

1 file changed

+5
-4
lines changed

gix/Cargo.toml

Lines changed: 5 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -124,10 +124,11 @@ blocking-http-transport-curl = ["blocking-network-client", "gix-transport/http-c
124124
blocking-http-transport-curl-rustls = ["blocking-http-transport-curl", "dep:curl-for-configuration-only", "curl-for-configuration-only?/rustls"]
125125
## Stacks with `blocking-network-client` to provide support for HTTP/S using **reqwest**, and implies blocking networking as a whole, making the `https://` transport avaialble.
126126
blocking-http-transport-reqwest = ["blocking-network-client", "gix-transport/http-client-reqwest"]
127-
## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `rustls` crate. Enables `trust-dns` on `reqwest`.
128-
blocking-http-transport-reqwest-rust-tls = ["blocking-http-transport-reqwest", "reqwest-for-configuration-only/rustls-tls", "reqwest-for-configuration-only/trust-dns"]
129-
## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `rustls` crate.
130-
blocking-http-transport-reqwest-rust-tls-no-trust-dns = ["blocking-http-transport-reqwest", "reqwest-for-configuration-only/rustls-tls"]
127+
## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `rustls` crate.
128+
blocking-http-transport-reqwest-rust-tls = ["blocking-http-transport-reqwest", "reqwest-for-configuration-only/rustls-tls" ]
129+
## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `rustls` crate.
130+
## This also makes use of `trust-dns` to avoid `getaddrinfo`, but note it comes with its own problems.
131+
blocking-http-transport-reqwest-rust-tls-trust-dns = ["blocking-http-transport-reqwest", "reqwest-for-configuration-only/rustls-tls", "reqwest-for-configuration-only/trust-dns"]
131132
## Stacks with `blocking-http-transport-reqwest` and enables `https://` via the `native-tls` crate.
132133
blocking-http-transport-reqwest-native-tls = ["blocking-http-transport-reqwest", "reqwest-for-configuration-only/default-tls" ]
133134

0 commit comments

Comments
 (0)